This repository was archived by the owner on May 30, 2024. It is now read-only.
Use a thread-safe Jedis pool #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private final JedisPoolConfig getPoolConfig() { | ||
| JedisPoolConfig config = new JedisPoolConfig(); | ||
| config.setMaxTotal(256); | ||
| config.setBlockWhenExhausted(false); |
There was a problem hiding this comment.
Due to the nature of the store abstraction, blocking when exhausted can cause a deadlock. This can happen because a single toggle call can require multiple jedis pool connections to complete-- one to check whether the store is initialized, and another to fetch the value from the store. If multiple threads attempt to do this concurrently, and the pool is near exhaustion, they could all acquire connections to check initialization, and then block waiting for another connection to fetch the store value.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.