This repository was archived by the owner on May 30, 2024. It is now read-only.
Bump EventSource library, and make reconnect times configurable #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drichelson
reviewed
Oct 6, 2016
| @@ -24,6 +24,7 @@ | |||
| private static final long DEFAULT_POLLING_INTERVAL_MILLIS = 1000L; | |||
| private static final long DEFAULT_START_WAIT_MILLIS = 5000L; | |||
| private static final int DEFAULT_SAMPLING_INTERVAL = 0; | |||
| private static final long DEFAULT_RECONNECT_TIME_MS = 1000; | |||
There was a problem hiding this comment.
tiny nitpick: we're using _MILLIS to denote the unit in other constants, but _MS here.
|
lgtm |
drichelson
approved these changes
Oct 7, 2016
eli-darkly
added a commit
that referenced
this pull request
Jun 26, 2018
add custom attribute overloads for arbitrary JSON value
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #74