Skip to content

Conversation

yusinto
Copy link
Contributor

@yusinto yusinto commented Apr 29, 2023

fix: bump cloudflare sdk dep

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #199494: Bump cloudflare example dep.

@kinyoklion
Copy link
Member

This is a "fix" which will make another release, is that what you want?

@kinyoklion
Copy link
Member

What we could do, doesn't need to be right now, is have "packages/example/cloudflare". Then we add that to the workspace. Let release-please manage the version, but just don't publish it.

@yusinto
Copy link
Contributor Author

yusinto commented May 1, 2023

For now, a patch release is fine I think. Otherwise the example app fails due to the serialization bug, which is not very good for our customers. Is that ok with you please?

@kinyoklion
Copy link
Member

For now, a patch release is fine I think. Otherwise the example app fails due to the serialization bug, which is not very good for our customers. Is that ok with you please?

I approved, but I wasn't sure if someone would be running an example from the package, or the repo. If it is just the repo, then you just need a "chore". But if you want it updated in the package, then this is the right thing to do.

@yusinto
Copy link
Contributor Author

yusinto commented May 1, 2023

Good point re your last comment. Preferably both scenarios should work, so the caret added should somewhat solve this kind of patch releases to a certain extent. Agree we may need to re-structure the example location.

@yusinto yusinto merged commit df9533f into main May 1, 2023
@yusinto yusinto deleted the yus/sc-199494/bump-cloudflare-example-dep branch May 1, 2023 16:36
@github-actions github-actions bot mentioned this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants