Skip to content

fix: Do not mangle _meta. #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fix: Do not mangle _meta. #622

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e94145
fix: Do not mangle _meta.
kinyoklion Oct 10, 2024
733fb50
Comments
kinyoklion Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions packages/sdk/browser/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,18 @@ const getSharedConfig = (format, file) => ({
},
});

const terserOpts = {
mangle: {
properties: {
// Mangle class properties which start with an underscore.
regex: /^_/,
// Do not mangle '_meta', because this is part of our JSON
// data model.
reserved: ['_meta']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better than a regex even.

},
}
};

export default [
{
...getSharedConfig('es', 'dist/index.es.js'),
Expand All @@ -33,13 +45,7 @@ export default [
esmExternals: true,
}),
resolve(),
terser({
mangle: {
properties: {
regex: /^_/,
},
},
}),
terser(terserOpts),
json(),
// The 'sourcemap' option allows using the minified size, not the size before minification.
visualizer({ sourcemap: true }),
Expand All @@ -51,13 +57,7 @@ export default [
typescript(),
common(),
resolve(),
terser({
mangle: {
properties: {
regex: /^_/,
},
},
}),
terser(terserOpts),
json(),
],
},
Expand Down