Skip to content

feat: Expose LDClient from provider #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ld_openfeature/provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,15 @@ def __init__(self, config: Config):
self.__context_converter = EvaluationContextConverter()
self.__details_converter = ResolutionDetailsConverter()

@property
def client(self) -> LDClient:
"""
Access the underlying LaunchDarky client instance backing this provider.

This is useful for accessing additional functionality not exposed by the provider.
"""
return self.__client

def __handle_data_source_status(self, status: DataSourceStatus):
state = status.state
if state == DataSourceState.INITIALIZING:
Expand Down
4 changes: 4 additions & 0 deletions tests/test_provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ def test_metadata_name_is_correct(provider: LaunchDarklyProvider):
assert provider.get_metadata().name == "launchdarkly-openfeature-server"


def test_ldclient_is_accessible(provider: LaunchDarklyProvider):
assert type(provider.client) is LDClient


def test_not_providing_context_returns_error(provider: LaunchDarklyProvider):
resolution_details = provider.resolve_boolean_details("flag-key", True, None)

Expand Down