fix: Shutdown diagnostic thread if enabled #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
commented
Sep 27, 2024
| @@ -44,6 +44,7 @@ class DebugEvent: | |||
| def __init__(self, original_input: EventInputEvaluation): | |||
| self.original_input = original_input | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Lots of little whitespace changes while I was in this file. You can ignore pretty much everything except the 3 lines I'll call out.
Comment on lines
+495
to
+497
| if self._diagnostic_flush_workers: | ||
| self._diagnostic_flush_workers.stop() | ||
| self._diagnostic_flush_workers.wait() |
There was a problem hiding this comment.
And here are those 3 lines.
cwaldren-ld
approved these changes
Oct 1, 2024
keelerm84
pushed a commit
that referenced
this pull request
Oct 1, 2024
🤖 I have created a release *beep* *boop* --- ## [9.7.2](9.7.1...9.7.2) (2024-10-01) ### Bug Fixes * Set explicit names for each spawned thread ([#311](#311)) ([9c7777c](9c7777c)) * Shutdown diagnostic thread if enabled ([#312](#312)) ([cde6cfb](cde6cfb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.