Reconnect when no data is received for 5 minutes. #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drichelson
commented
Dec 23, 2016
|
|
||
| name = m.groupdict()['name'] | ||
| value = m.groupdict()['value'] | ||
| if name == '': |
There was a problem hiding this comment.
this wasn't actually working.
drichelson
commented
Dec 23, 2016
| self.resp = requester.get( | ||
| self.url, | ||
| stream=True, | ||
| timeout=(self._connect_timeout, self._read_timeout), |
There was a problem hiding this comment.
Setting the read_timeout here means that the request will throw a timeout error if no data is received for 5 minutes.. thus implementing heartbeat detection.
pkaeding
approved these changes
Dec 28, 2016
jkodumal
reviewed
Jan 10, 2017
ldclient/streaming.py
Outdated
| store.delete(key, version) | ||
| else: | ||
| log.warning('Unhandled event in stream processor: ' + msg.event) | ||
| elif msg.event != 'comment': |
jkodumal
reviewed
Jan 10, 2017
ldclient/sse_client.py
Outdated
| and return a Event object. | ||
| """ | ||
| msg = cls() | ||
| if raw.startswith(':'): |
There was a problem hiding this comment.
Remove this-- not necessary.
|
👍 |
added 2 commits
January 9, 2017 19:03
eli-darkly
added a commit
that referenced
this pull request
Aug 3, 2018
better log output for stream failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reconnect when no data is received for 5 minutes.