Fix import of parse_requirements #81
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting in pip 10.x, parse_requirements was moved to an internal namespace to help demonstrate the fact that it is not a public API. As a workaround until a broader decision can be made about how this should look long term, this change attepts to perform the import using the pip 10.x path and if it fails, falls back on the older path. Fixes launchdarkly#80.
|
We're going to go with a different approach just to avoid importing any internal APIs, but thanks for submitting this. |
|
No worries. Just trying to get something out quick and fast since this caused a lot of pain for a lot of people when pip 10.x was released. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in pip 10.x, parse_requirements was moved to an internal
namespace to help demonstrate the fact that it is not a public API.
As a workaround until a broader decision can be made about how this
should look long term, this change attepts to perform the import using
the pip 10.x path and if it fails, falls back on the older path.
Fixes #80.