-
Notifications
You must be signed in to change notification settings - Fork 55
Closed
Description
The usage reference in comments show you can start call LaunchDarkly::Integrations::DynamoDB.new_feature_store
with just the table name, but it actually requires 2 args right now. However, I think it'd be more ergonomic if opts
defaulted to an empty hash.
Suggestion:
Change the new_feature_store function signature to def self.new_feature_store(table_name, opts = {})
This appears to not directly impact the other feature store implementations, though it's clear there's some mismatch in design (FileData defaults to empty hash, but Consul and Redis require opts
even if it's an empty hash).
Ideally I'd want to not pass in an empty hash. But at the very least, the usage docs should match the implementation
Usage reference:
# store = LaunchDarkly::Integrations::DynamoDB::new_feature_store("my-table-name") |
Metadata
Metadata
Assignees
Labels
No labels