Skip to content

Log "unknown feature flag" as a warning instead of info #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Log "unknown feature flag" as a warning instead of info #165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23847c2
Make unknown feature flags at least a warning
nc-wittj Sep 22, 2020
f4e6c3c
Add a few missing [LDClient] prefixes
nc-wittj Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/ldclient-rb/ldclient.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ def variation_detail(key, user, default)
#
def identify(user)
if !user || user[:key].nil?
@config.logger.warn("Identify called with nil user or nil user key!")
@config.logger.warn("[LDClient] Identify called with nil user or nil user key!")
return
end
sanitize_user(user)
Expand Down Expand Up @@ -271,7 +271,7 @@ def identify(user)
#
def track(event_name, user, data = nil, metric_value = nil)
if !user || user[:key].nil?
@config.logger.warn("Track called with nil user or nil user key!")
@config.logger.warn("[LDClient] Track called with nil user or nil user key!")
return
end
sanitize_user(user)
Expand Down Expand Up @@ -367,8 +367,8 @@ def create_default_data_source(sdk_key, config, diagnostic_accumulator)
if config.stream?
StreamProcessor.new(sdk_key, config, requestor, diagnostic_accumulator)
else
config.logger.info { "Disabling streaming API" }
config.logger.warn { "You should only disable the streaming API if instructed to do so by LaunchDarkly support" }
config.logger.info { "[LDClient] Disabling streaming API" }
config.logger.warn { "[LDClient] You should only disable the streaming API if instructed to do so by LaunchDarkly support" }
PollingProcessor.new(config, requestor)
end
end
Expand All @@ -393,7 +393,7 @@ def evaluate_internal(key, user, default, event_factory)
feature = @store.get(FEATURES, key)

if feature.nil?
@config.logger.info { "[LDClient] Unknown feature flag \"#{key}\". Returning default value" }
@config.logger.warn { "[LDClient] Unknown feature flag \"#{key}\". Returning default value" }
detail = error_result('FLAG_NOT_FOUND', default)
@event_processor.add_event(event_factory.new_unknown_flag_event(key, user, default, detail.reason))
return detail
Expand Down