More refactoring and add tests #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
albertyw
force-pushed
the
refactor
branch
6 times, most recently
from
5350ba1 to
9f9420b
Compare
|
👍 |
lib/ldclient-rb/ldclient.rb
Outdated
There was a problem hiding this comment.
we should probably check if the status is >= 300, since other 2xx responses could still indicate that everything is okay. (I realize that this is unchanged from before, but I just noticed it here.)
There was a problem hiding this comment.
I changed this to res.status/100 != 2 since I assume 100 Continue responses are also not accepted. I also fixed 2 other places where it was checking for 200 specifically.
|
I saw a few sporadic integration test failures when I bumped the REST wrapper to this branch. Investigating. |
|
@jkodumal FYI I've rebased and added 3 more commits though it shouldn't change the test status. |
|
Errors were fixed in #42 |
albertyw
added a commit
that referenced
this pull request
Nov 1, 2015
More refactoring and add tests
ashanbrown
pushed a commit
that referenced
this pull request
Jan 23, 2018
fix 1.0 documentation link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.