Attempt to fix potential race condition with em-http-request #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
| source.inactivity_timeout = 0 | ||
| source.start | ||
| EM.schedule{ source.start } |
There was a problem hiding this comment.
Stylistically it's good to have a space before the {
EM.schedule { source.start }
|
I've also got to fix the tests on this one-- just getting the PR up so that @jhubert can test this out. |
|
Installed locally. About to head for a lunch meeting but I'll see if we end up in that state when i get back. |
|
This did not address the issue-- in addition we're moving forward with Celluloid instead of EventMachine. |
eli-darkly
added a commit
that referenced
this pull request
May 10, 2018
miscellaneous event-related fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.