Switch to celluloid-based eventsource implementation #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldclient-rb.gemspec
Outdated
| spec.add_runtime_dependency "concurrent-ruby", "~> 1.0.0" | ||
| spec.add_runtime_dependency "hashdiff", "~> 0.2" | ||
| spec.add_runtime_dependency "ld-em-eventsource", "~> 0.2" | ||
| #spec.add_runtime_dependency "ld-em-eventsource", "~> 0.2" |
There was a problem hiding this comment.
Should this be removed instead of commented?
|
Seems reasonable- Has Jeremy tried out this branch? |
|
Sorry guys. Been a crazy few weeks. Trying out this branch now. |
|
I haven't seen any issues in two days. Since there was no clearly repeatable test case I can't say for sure that the issue has been fixed. I'm going to switch back to try and recreate it with the EM version. |
|
Thanks for trying it out! we'll merge and release a new version in the coming days. |
eli-darkly
added a commit
that referenced
this pull request
May 10, 2018
send as much of a feature event as possible even if user is invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates our dependency on EventMachine and replaces it with a Celluloid-based library for EventSource