Auto-register user within #get_user_settings as well #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our current use case, we're using
get_user_settings
to expose all flags for a given user at once. For the most part, that works great.However,
toggle?
has the nice side-effect of auto-registering the users we call it with, which we don't get to have with this method. Callingidentify
for each user we want to get all flags of (whether at the time of the call or on a schedule) seems like a weird divergence from howtoggle?
Just Works ™️I didn't want to call
add_event
directly, asidentify
does exactly the thing that we're looking for here, so I just delegated that.This would be super helpful. Let me know if I'm missing something.