Update to v2 #67
Merged
Update to v2 #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d all_flags implementations
…t contain a prereq.
| data = File.read(File.join("spec", "fixtures", "sanitized_numeric_key_user.json")) | ||
| JSON.parse(data, symbolize_names: true) | ||
| end | ||
|
|
There was a problem hiding this comment.
These tests certainly need to be re-added. As part of the refactoring, the client class itself has been broken up pretty substantially, so most of this can be moved to an evaluation_spec.rb file that tests the evaluation module.
However, I think it's worth reviewing this now-- the tests will be re-added in a follow up PR. This is passing the v2 integration harness so the evaluation part is pretty solid.
|
👍 |
lib/ldclient-rb/evaluation.rb
Outdated
| lambda do |a, b| | ||
| (a.is_a? Numeric) && (a >= b) | ||
| end, | ||
| greaterThanOrEqual: |
eli-darkly
added a commit
that referenced
this pull request
Jun 26, 2018
reimplement SSE client without Celluloid [1 of 2]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.