Skip to content

Add http proxy support #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 8, 2017
Merged

Add http proxy support #87

merged 4 commits into from
May 8, 2017

Conversation

dlau
Copy link
Contributor

@dlau dlau commented May 8, 2017

Adds proxy support to the ruby sdk.

The new configuration option is as follows:

{ :proxy => "protocol://url:port" }

With this change:

  1. HTTP Proxies are configurable via the above parameter.
  2. HTTP Proxies are also configurable via the HTTP_PROXY and http_proxy environment variables.

@dlau dlau requested a review from adamlaunchingdarkly May 8, 2017 20:31
adamlaunchingdarkly
adamlaunchingdarkly approved these changes May 8, 2017
View reviewed changes
Copy link
Contributor

@adamlaunchingdarkly adamlaunchingdarkly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@dlau dlau merged commit 0b0dcb7 into master May 8, 2017
@ashanbrown ashanbrown deleted the proxy branch October 27, 2017 14:33
eli-darkly added a commit that referenced this pull request Jan 17, 2019
@eli-darkly
Merge pull request #87 from launchdarkly/eb/docs
216a1e8 
greatly improve documentation comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@adamlaunchingdarkly adamlaunchingdarkly adamlaunchingdarkly approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlau @adamlaunchingdarkly