Use Logger block form calls #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When blocks are used, and the set logging level of the Logger object is above that of the call, the block will not be executed. This prevents string allocations in log messages that would not be retained anyway, which can be especially significant when calling `inspect` on large-ish objects. For rationale, see http://hawkins.io/2013/08/using-the-ruby-logger/ and https://stackoverflow.com/questions/30144317
|
Looks good, and works fine in tests. Thanks! |
eli-darkly
added a commit
that referenced
this pull request
Jan 18, 2019
add YARD config so our docs show up correctly everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When blocks are used, and the set logging
level of the Logger object is above that of
the call, the block will not be executed.
This prevents string allocations in log
messages that would not be retained anyway,
which can be especially significant when
calling
inspecton large-ish objects.For rationale, see http://hawkins.io/2013/08/using-the-ruby-logger/
and https://stackoverflow.com/questions/30144317