Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNS 231 consumer create project #334

Merged
merged 92 commits into from
Mar 3, 2023
Merged

CNS 231 consumer create project #334

merged 92 commits into from
Mar 3, 2023

Conversation

Yaroms
Copy link
Collaborator

@Yaroms Yaroms commented Mar 2, 2023

  • Please check if the PR fulfills these requirements
  • Commit message follows the Contribution Guidelines
  • Tests ran locally and added/modified if needed
  • Docs have been added/updated, if applicable
  • If applicable - JIRA ticket ID was added

  • What kind of change does this PR introduce? (Bug fix, feature, unit tests, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Please describe what manual tests you ran, if applicable

  • Other information:

oren-lava and others added 30 commits January 31, 2023 14:26
CNS-268: created packageManager module
e82dab3
CNS-268: created package protobuf
ff2bafb
CNS-268: created generic fixation manager
e0d1bd6
CNS-268: changed package and paramFixation proto
5e0cf6a
CNS-268: created packagemanager module and implemented package storag…
07244c3 
…e handlers
CNS-268: fix lint issues
e247096
CNS-268: added package deletion on epoch start
12d5c7d
CNS-268: renamed the module to packages (orig name: packagemanager)
1485238
CNS-268: added func to update subs, changed package deletoion criterion
6147447
CNS-268: added vote proposal support
69929f5
CNS-268: added type and description to package proto
43da929
CNS-268: fixed part of a package's validation
594458d
CNS-268: removed unnecessary proposal funcs
e3a4ecf
CNS-268: finished vote proposal
cf4f3ba
CNS-268: fixed vote proposal
1de80f8
CNS-268: implemented show-all-packages query
ab9a6e2
CNS-268: bug fixes
09447cb
CNS-268: added show-package-info query
a0bea14
CNS-268: bug fixes
0cab70b
CNS-268: implemented unit tests
4f9046c
CNS-268: changed the way entryFixation works, updated packages module…
7c136fe 
… accordingly (added in packages module unique index list)
CNS-268: fixed bugs, added unit test, added example of package propos…
b96eb1d 
…al json
Merge branch 'main' into CNS-268-implement-package-module
54b6d26
Merge branch 'main' into CNS-268-implement-package-module
fb2479f
CNS-268: fix epochstorage API signatures and lint issues
088429a
CNS-268: fixed PR issues
1f58e34
CNS-268: moves specs to their original folder
1099953
common now knows how to use the store
971033d
CNS-268: upgrade plan + fix new design. still left TODOs
7806274
CNS-268: fixation entry now also manages unique indices, bug fixes an…
2748480 
…d unit tests
oren-lava
oren-lava previously requested changes Mar 2, 2023
View reviewed changes
proto/projects/project.proto Outdated Show resolved Hide resolved
proto/projects/project.proto Show resolved Hide resolved
proto/projects/project.proto Outdated Show resolved Hide resolved
proto/projects/project.proto Show resolved Hide resolved
proto/projects/project.proto Show resolved Hide resolved
x/projects/keeper/creation.go Outdated Show resolved Hide resolved
x/projects/keeper/creation.go Outdated Show resolved Hide resolved
x/projects/keeper/project.go Outdated Show resolved Hide resolved
x/projects/keeper/project.go Outdated Show resolved Hide resolved
x/projects/keeper/project.go Outdated Show resolved Hide resolved
orenl-lava
orenl-lava reviewed Mar 2, 2023
View reviewed changes
proto/projects/project.proto Outdated Show resolved Hide resolved
proto/projects/project.proto Outdated Show resolved Hide resolved
x/projects/types/project.go Outdated Show resolved Hide resolved
x/projects/types/project.go Outdated Show resolved Hide resolved
x/projects/keeper/creation.go Outdated Show resolved Hide resolved
x/projects/keeper/project.go Outdated Show resolved Hide resolved
x/projects/keeper/project.go Outdated Show resolved Hide resolved
x/projects/keeper/creation.go Outdated Show resolved Hide resolved
x/projects/keeper/project.go Outdated Show resolved Hide resolved
x/projects/keeper/project.go Outdated Show resolved Hide resolved
orenl-lava
orenl-lava reviewed Mar 2, 2023
View reviewed changes
Copy link
Contributor

@orenl-lava orenl-lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subscription also needs an API to delete all the projects that refer to it.

x/projects/keeper/creation.go Outdated Show resolved Hide resolved
@orenl-lava orenl-lava changed the title Cns 231 consumer create project CNS 231 consumer create project Mar 3, 2023
@Yaroms Yaroms merged commit 87327fd into CNS-231-ProjectModule-scaffold Mar 3, 2023
@Yaroms Yaroms deleted the CNS-231-consumer-create-project branch July 31, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orenl-lava orenl-lava orenl-lava left review comments

@oren-lava oren-lava oren-lava left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yaroms @oren-lava @orenl-lava @yuvalava