Fix unsafe extraction by using mkdir() instead of shell command #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rofl0r
reviewed
Sep 20, 2016
| @@ -305,20 +309,20 @@ void processFile(struct Volume *vol, char* name, char* path, unsigned char *extb | |||
| } | |||
| else { | |||
| /* the all-in-one string : to call system(), to find the filename, the convert dir sep char ... */ | |||
There was a problem hiding this comment.
looks like the comment needs an update as well...
There was a problem hiding this comment.
True, thanks. I'll force-update the pull request to just update the comments. I'll remove that comment and modify the comment about portability at the top of the file.
p.s. extractTree() needs quite a bit cleaning/refactoring, but that needs to be done separately.
This commit fixes following vulnerabilities: - CVE-2016-1243: stack buffer overflow caused by blindly trusting on pathname lengths of archived files Stack allocated buffer sysbuf was filled with sprintf() without any bounds checking in extracTree() function. - CVE-2016-1244: execution of unsanitized input Shell command used for creating directory paths was constructed by concatenating names of archived files to the end of the command string. So, if the user was tricked to extract a specially crafted .adf file, the attacker was able to execute arbitrary code with privileges of the user. This commit fixes both issues by 1) replacing mkdir shell commands with mkdir() function calls 2) removing redundant sysbuf buffer
tuomasjjrasanen
force-pushed
the
master
branch
from
b9f6b14
to
8e973d7
Compare
lclevy
approved these changes
Sep 21, 2016
There was a problem hiding this comment.
Correctly fixes CVE-2016-1243 and CVE-2016-1244, thank you Tuomas !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes following vulnerabilities:
CVE-2016-1243: stack buffer overflow caused by blindly trusting on
pathname lengths of archived files
Stack allocated buffer sysbuf was filled with sprintf() without any
bounds checking in extracTree() function.
CVE-2016-1244: execution of unsanitized input
Shell command used for creating directory paths was constructed by
concatenating names of archived files to the end of the command
string.
So, if the user was tricked to extract a specially crafted .adf file,
the attacker was able to execute arbitrary code with privileges of the
user.
This commit fixes both issues by