Skip to content

Avoid verifying IntrinsicFunction if check_external is False #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Avoid verifying IntrinsicFunction if check_external is False #2155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/libasr/asr_verify.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -974,6 +974,10 @@ class VerifyVisitor : public BaseWalkVisitor<VerifyVisitor>
}

void visit_IntrinsicFunction(const ASR::IntrinsicFunction_t& x) {
if( !check_external ) {
BaseWalkVisitor<VerifyVisitor>::visit_IntrinsicFunction(x);
return ;
}
ASRUtils::verify_function verify_ = ASRUtils::IntrinsicFunctionRegistry
::get_verify_function(x.m_intrinsic_id);
LCOMPILERS_ASSERT(verify_ != nullptr);
Expand Down
8 changes: 8 additions & 0 deletions src/libasr/serialization.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,14 @@ ASR::asr_t* deserialize_asr(Allocator &al, const std::string &s,
ASR::FixParentSymtabVisitor p;
p.visit_TranslationUnit(*tu);

#if defined(WITH_LFORTRAN_ASSERT)
diag::Diagnostics diagnostics;
if (!asr_verify(*tu, false, diagnostics)) {
std::cerr << diagnostics.render2();
throw LCompilersException("Verify failed");
};
#endif

return node;
}

Expand Down