Added str.replace()

[Kishan-Ved]

Towards: #2356

In this PR, I have implemented str.replace() completely. Relevant tests have also been added.

Parameters:

• old – old substring you want to replace.
• new – new substring which would replace the old substring.
• count – (Optional ) the number of times you want to replace the old substring with the new substring.

[Kishan-Ved]

I don't get any errors upon running ./run_tests.py locally. However, here, 2 checks fail due to this. Please let me know the fix for this. @Thirumalai-Shaktivel @Shaikh-Ubaid

[Thirumalai-Shaktivel]

It's the C test that fails, you can reproduce it using the following command:

$ cd integration_tests
$ ./run_tests.py -b c

[Thirumalai-Shaktivel]

Please mark this PR ready for review once it is ready!

[Kishan-Ved]

It's the C test that fails, you can reproduce it using the following command:

$ cd integration_tests
$ ./run_tests.py -b c

Fixed. Thank you @Thirumalai-Shaktivel .

[Kishan-Ved]

@Shaikh-Ubaid @Thirumalai-Shaktivel Please let me know if this is good to be merged.

[Shaikh-Ubaid]

I think the implementation fails for the following example:

% cat examples/expr2.py   
from lpython import i32

def main0():
    x: str
    x = "abc"
    print(x.replace("", ","))
    assert x.replace("", ",") == ",a,b,c,"

main0()
% python examples/expr2.py
,a,b,c,
% lpython examples/expr2.py
,a,b,c
AssertionError

[Kishan-Ved]

I think the implementation fails for the following example:

% cat examples/expr2.py   
from lpython import i32

def main0():
    x: str
    x = "abc"
    print(x.replace("", ","))
    assert x.replace("", ",") == ",a,b,c,"

main0()
% python examples/expr2.py
,a,b,c,
% lpython examples/expr2.py
,a,b,c
AssertionError

Fixed. Thanks.

[Shaikh-Ubaid]

How did this file got commited? I think it should not be present.

[Kishan-Ved]

I have not committed this, as this is in stdout, so I believe it is due to updated references.

[Shaikh-Ubaid]

I have not committed this, as this is in stdout, so I believe it is due to updated references.

Can you trying doing:

rm -rf tests/reference/* (then press 'y' if asked for confirmation)
./run_tests.py -u
git add tests
git commit -m "TEST: Update reference tests"

[Kishan-Ved]

What is supposed to happen? I did this, but nothing got committed.

[Kishan-Ved]

Upon rerunning these commands, I noticed there are no net changes. All the deleted files reappear.

[Shaikh-Ubaid]

Did you follow the exact steps in #2587 (comment)?

The output shared in #2587 (comment) seems strange and does not look like exact steps were used.

[Shaikh-Ubaid]

Upon rerunning these commands, I noticed there are no net changes. All the deleted files reappear.

Can you rebase over the latest main? I think that might help remove the stray file.

[Kishan-Ved]

I believe this has been done from your side. Thanks.

[Shaikh-Ubaid]

I think the file is now removed. We had to rebase over latest main, rebuild the project and then follow the steps in #2587 (comment).

[Kishan-Ved]

Ok, thanks. I'm deleting the output now, as it is too long.

[Shaikh-Ubaid]

We next need support for compile-time strings in replace. For example,

% cat examples/expr2.py 
def main0():
    print("abc".replace("", ","))

main0()
% python examples/expr2.py 
,a,b,c,
% lpython examples/expr2.py
semantic error: 'str' object has no attribute 'replace'
 --> examples/expr2.py:2:11
  |
2 |     print("abc".replace("", ","))
  |           ^^^^^^^^^^^^^^^^^^^^^^ 


Note: Please report unclear or confusing messages as bugs at
https://github.com/lcompilers/lpython/issues.

I think this can be tackled in a separate PR.

[Kishan-Ved]

Sure. Please let me know how to implement this. Also, is this done for all other functions?

[Shaikh-Ubaid]

Search for "upper" in python_ast_to_asr.cpp and you will find the place(s) for compile-time implementation.

I would suggest supporting it in a separate PR.

[Kishan-Ved]

Ok, thanks.

[Shaikh-Ubaid]

This looks good to me. Thanks for working on this! Great work! I appreciate it.