Fix the dedent token generation in new tokenizer
#363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshanshbhatt
changed the title
dedent token generation in new tokenizer
|
@akshanshbhatt thanks for the PR! @Thirumalai-Shaktivel would you mind reviewing it please? |
There was a problem hiding this comment.
Thanks for this PR @akshanshbhatt.
Yup, I just noticed that there is no need to sum up all the element's values in the indent_length, as the last element in the indent_length has the summed indent value.
I left some changes.
Thirumalai-Shaktivel
approved these changes
Apr 13, 2022
|
Thanks @akshanshbhatt for the PR and thanks @Thirumalai-Shaktivel for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tokenizer was throwing an error when the last line of the source code was dedented by one level less than the previous level. I debugged and fixed it.
Closes #358