Draft: Merging TemplateFunction into Function

[ansharlubis]

No description provided.

[certik]

@ansharlubis looks like we got to the point with @Oshanath that we need this merged, so that we can start using it.

@ansharlubis what is your time line to get this PR ready? It looks like the only thing left is to uncomment and fix the integration tests. Do you need help with this?

[ansharlubis]

@ansharlubis looks like we got to the point with @Oshanath that we need this merged, so that we can start using it.

@ansharlubis what is your time line to get this PR ready? It looks like the only thing left is to uncomment and fix the integration tests. Do you need help with this?

I can uncomment it right away, but it will cause the integration tests to fail.

[certik]

Thanks.

So this is now our highest priority. We need to get these tests to pass.

@ansharlubis any idea why they fail?

@Oshanath and @ansharlubis: try to take this PR, reproduce the failure of the test on your machine, and let's try to figure out how to fix it. Let me know what you find. Try to do your best today. Then we have our meeting tomorrow, so we can work on it together as well.

[ansharlubis]

I think I found out why, although I still don't know how to solve it yet. It seems that the addition of type_params into Function in ASR causes the array translation into LLVM to mess up.

[czgdp1807]

It seems that the addition of type_params into Function in ASR causes the array translation into LLVM to mess up.

Well, make_Function_t doesn't receive elemental attribute correctly in your branch. You are always passing false in that attribute (see below)

https://github.com/ansharlubis/lpython/blob/a489c1bf12212cbe6646b311cc5c3e6dd7eed801/src/lpython/semantics/python_ast_to_asr.cpp#L2366

It should be, s_access, deftype, vectorize, bindc_name); instead of s_access, deftype, false, bindc_name);

See the code from main branch for the same thing,

lpython/src/lpython/semantics/python_ast_to_asr.cpp

Line 2237 in f1965f0

s_access, deftype, vectorize, bindc_name);

[czgdp1807]

@certik @ansharlubis @Oshanath The tests are now passing. Feel free to clean up the git history before merging.

[ansharlubis]

@czgdp1807 thank you very much!

[certik]

Another one that needs to be uncommented:

Suggested change

	# [[test]]
	# filename = "../integration_tests/test_numpy_04.py"
	# asr = true
	[[test]]
	filename = "../integration_tests/test_numpy_04.py"
	asr = true

[certik]

Do not rebase this PR. Let's only keep pushing things in. That way we can get back to the version that @czgdp1807 fixed (thanks!).

@ansharlubis / @Oshanath can you please enable that one other test (see my comment above). Then merge the latest main into this branch and resolve conflicts? Get all tests passing again.

After that, I want to review more. I will be out for a few hours, but in the evening I'll give it a final review. Then we polish the patches and merge.

[certik]

You have to resolve these conflicts by merging the latest main branch:

[certik]

You have to run ./run_tests.py -u to update the tests.

[ansharlubis]

Got it, I just updated it with a wrong build. I'll have to fix it again.

[certik]

This was merged in #900.