Skip to content

[Parser] Parse type_comment in function args #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2022

Conversation

akshanshbhatt
Copy link
Collaborator

type_comment is now parsed correctly for all the possible cases in the new parser.
Refer to #801 (comment) for more information.

@Thirumalai-Shaktivel
Copy link
Collaborator

Thirumalai-Shaktivel commented Jul 29, 2022

LGTM! Thanks for this PR!
Once the above changes are resolved, this is good to go in.

@Thirumalai-Shaktivel Thirumalai-Shaktivel added the Parser Issues or improvements related to parser label Jul 29, 2022
Copy link
Collaborator

@Thirumalai-Shaktivel Thirumalai-Shaktivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Thirumalai-Shaktivel Thirumalai-Shaktivel merged commit e831123 into lcompilers:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Parser Issues or improvements related to parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants