Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Parser] Properly handle functions with * and / in the new parser #850

Merged
merged 4 commits into from
Jul 31, 2022
Merged

[Parser] Properly handle functions with * and / in the new parser #850

merged 4 commits into from
Jul 31, 2022

Conversation

akshanshbhatt
Copy link
Collaborator

Closes #513

@Thirumalai-Shaktivel Thirumalai-Shaktivel added the Parser Issues or improvements related to parser label Jul 31, 2022
@Thirumalai-Shaktivel
Copy link
Collaborator

Thirumalai-Shaktivel commented Jul 31, 2022 •
edited
Loading

After this PR is merged, I will start working on simplifying the grammar rules for the parameter_list_opt in function_def and submit another PR.

@Thirumalai-Shaktivel Thirumalai-Shaktivel marked this pull request as ready for review July 31, 2022 06:01
@Thirumalai-Shaktivel
Copy link
Collaborator

Thanks for opening a PR for this!

@Thirumalai-Shaktivel Thirumalai-Shaktivel changed the title [WIP][Parser] Properly handle functions with * and / in the new parser [Parser] Properly handle functions with * and / in the new parser Jul 31, 2022
@Thirumalai-Shaktivel Thirumalai-Shaktivel merged commit b82d617 into lcompilers:main Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thirumalai-Shaktivel Thirumalai-Shaktivel Thirumalai-Shaktivel approved these changes

Assignees
No one assigned
Labels
Parser Issues or improvements related to parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New] Parse / and * as a parameter in function definition
2 participants
@akshanshbhatt @Thirumalai-Shaktivel