Adding type parameters to functions without return values #957
Conversation
|
I think that this is good. Should we add some tests now or later? |
|
Do you mean tests for subroutines? I can do that right away. |
|
Turned out there really were problems with subroutines, so I made some more modifications and added a swapping example. |
integration_tests/generics_01.py
Outdated
| @@ -6,5 +6,3 @@ def f(x: T, y: T) -> T: | |||
| return x + y | |||
|
|
|||
| print(f(1,2)) | |||
| print(f("a","b")) | |||
| print(f("c","d")) | |||
| [2m File "[0m[1m[35m$DIR/src/libasr/pass/instantiate_template.cpp[39m[0m[2m", line 327, in LFortran::pass_instantiate_generic_function(Allocator&, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, LFortran::ASR::ttype_t*, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, LFortran::ASR::ttype_t*> > >, LFortran::SymbolTable*, int, LFortran::ASR::Function_t&)[0m | ||
| ASR::asr_t *new_function = tf.instantiate_Function(func); | ||
| [2m File "[0m[1m[35m$DIR/src/libasr/pass/instantiate_template.cpp[39m[0m[2m", line 61, in LFortran::FunctionInstantiator::instantiate_Function(LFortran::ASR::Function_t&)[0m | ||
| (ASR::down_cast<ASR::Var_t>(x.m_return_var))->m_v); |
| @@ -796,6 +879,7 @@ class CommonVisitor : public AST::BaseVisitor<Derived> { | |||
| visit_expr_list_with_cast(func->m_args, func->n_args, args_new, args); | |||
| return ASR::make_SubroutineCall_t(al, loc, stemp, | |||
| s_generic, args_new.p, args_new.size(), nullptr); | |||
| */ | |||
There was a problem hiding this comment.
If this section is not needed anymore, should it be removed?
|
Otherwise this looks good in general. |
|
I've cleaned up the rest, if this passes the check I'll merge and clean the git history as well. |
integration_tests/generics_01.py
Outdated
| @@ -7,4 +7,4 @@ def f(x: T, y: T) -> T: | |||
|
|
|||
| print(f(1,2)) | |||
| print(f("a","b")) | |||
| print(f("c","d")) | |||
| print(f("c","d")) | |||
There was a problem hiding this comment.
This is just a small thing, but if the only change is just a white space, let's not do it in this PR, you can fix that by:
git checkout main integration_tests/generics_01.py
Then update tests too, it will remove the change in the reference result for this.
| @@ -761,41 +775,27 @@ class CommonVisitor : public AST::BaseVisitor<Derived> { | |||
| return ASR::make_Assignment_t(al, loc, variable_var, ASRUtils::EXPR(func_call_asr), nullptr); | |||
| } else { | |||
| return func_call_asr; | |||
| } | |||
| } | |||
|
If you do a final rebase / polishing of the git history, please ping me one more time before the merge, so that I can review everything. |
|
I think that looks good. If tests pass, you can go ahead and polish the commits. |
|
Please check PR #989 where I've cleaned up the history. |
No description provided.