Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding type parameters to functions without return values (cleaned history) #989

Merged
merged 3 commits into from
Aug 19, 2022
Merged

Adding type parameters to functions without return values (cleaned history) #989

merged 3 commits into from
Aug 19, 2022

Conversation

ansharlubis
Copy link
Collaborator

Cleaned up PR #957

@ansharlubis ansharlubis mentioned this pull request Aug 19, 2022
Closed
certik
certik approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thanks for the PR, I reviewed all commits, I think this looks good.

@certik certik merged commit c982a7a into lcompilers:main Aug 19, 2022
@ansharlubis ansharlubis deleted the subroutine-template-clean branch August 24, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ansharlubis @certik