feat: add controllers to deal with client credentials flow #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashin5
reviewed
Sep 27, 2020
yashin5
reviewed
Sep 27, 2020
Comment on lines
+91
to
+98
| defp validate_grant_flows(%{valid?: true, changes: %{grant_flows: flows}} = changeset) do | ||
| if Enum.all?(flows, &(&1 in @possible_grant_flows)) do | ||
| changeset | ||
| else | ||
| opts = [validation: :subset, enum: @possible_grant_flows] | ||
| add_error(changeset, :grant_flows, "is invalid", opts) | ||
| end | ||
| end |
There was a problem hiding this comment.
this function is just to give a customized response?
There was a problem hiding this comment.
Yeah !
It's better to add the error as a changeset validation failure because that's the expected response.
This helps out a lot when we have a default controller fallback that know how to handle changeset errors.
yashin5
reviewed
Sep 27, 2020
Nel-Medeiros
approved these changes
Sep 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we also accepts client credentials flow on sign in endpoint.