feat: authentication flows now accepts client assertions #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcpojr
changed the title
lcpojr
commented
Sep 27, 2020
| @spec sign_out(conn :: Plug.Conn.t(), params :: map()) :: Plug.Conn.t() | ||
| def sign_out(%{private: %{session: session}} = conn, _params) do | ||
| session | ||
| session.jti |
There was a problem hiding this comment.
@yashin5 this is what was crashing the logout -.-.
I removed this param unintentionally and as the API tests are mocked i didn't noticed at all xD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authentication flows that requires credentials as
Resource OwnerandClient Credentialsnow accepts client assertions.It's important to avoid passing the raw secret on requests.
In this case the client application sends a JWT that is signed with it's private key and we verify it's signature using the public key stored on the
ResourceManager. The required claims on JWT areexp,iat,nbf,iss,aud,jti,sub,typ.The request payload should send the following new params:
client_assertions(JWT signed by private key and containing the required claims);client_assertion_type(should beurn:ietf:params:oauth:client-assertion-type:jwt-bearer);