Skip to content

Conversation

yashin5
Copy link
Collaborator

@yashin5 yashin5 commented Dec 9, 2020

this pr aims to separate the router in different contexts

@yashin5 yashin5 requested a review from lcpojr December 9, 2020 01:08
@yashin5 yashin5 force-pushed the feat/split_routers branch 2 times, most recently from d5fbf39 to e05c3b4 Compare December 9, 2020 01:33
@@ -0,0 +1,3 @@
[
{ "lib/phoenix/router.ex", :pattern_match, 402 }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lcpojr to resolve the dialyzer warning about phoenix, this is the solution i've found -> https://elixirforum.com/t/dialyzer-error-when-using-phoenix-router-match-5/32121/3

@lcpojr lcpojr merged commit 0d79640 into master Feb 24, 2021
@lcpojr lcpojr deleted the feat/split_routers branch February 24, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants