[ltsmaster] Fix backport of PR #2315. #2594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change is to fix debuginfo build errors with Phobos and LLVM5.0. This PR is mostly copy-pasting from master and fixing compile errors, so not much checking whether things make sense or not for LTS.
A changed condition leads to a missing load.
| // Sets the (current) value for a debuginfo variable. | ||
| void ldc::DIBuilder::SetValue(const Loc &loc, llvm::Value *value, | ||
| ldc::DILocalVariable divar | ||
| #if LDC_LLVM_VER >= 306 |
There was a problem hiding this comment.
LLVM 3.6 support was dropped in master. Do we still support it in ltsmaster?
There was a problem hiding this comment.
Yes, we still support LLVM 3.6 in ltsmaster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A changed condition leads to a missing load.