-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to using SPIR-V support as an external library #2935
Adapt to using SPIR-V support as an external library #2935
Conversation
b41078e
to
708d573
Compare
Fixed semicolons, fixed windows (good god I hate it). |
I'll do a release of LLVM sometime this week. |
Release done, heres hoping that travis config works. |
1fbfa13
to
2785135
Compare
f86ff59
to
0f65071
Compare
Finally it passes. |
0f65071
to
58202de
Compare
Thanks for the review. |
It'd be nice to include the translator as git submodule of our LLVM fork once we upgrade to v8. It should be as simple as adding the submodule in the right location ( |
I'm only doing some copying (all of ~3MB) for out-of-tree because I can't be bothered to figure out how to tell lit where the binary is. For in-tree, I'm pretty sure it would be. |
This good to go now? |
lgtm |
So this means that all releases of LDC will support SPIR-V output? |
It means they can. When we transition to releases with LLVM 8 (I think we release with 6 atm, @kinke?) I assume it will be enabled. |
We release with 7.0.1. |
Wow thanks for this, I just discovered LDC could generate OpenCL friendly SPIR-V! |
Pleasure, when we get around to releasing with LLVM 15/16 (depending on the maturity of the new SPIR-V backend) we will transition to using that. |
For use with https://github.com/KhronosGroup/SPIRV-LLVM-Translator now that I finally managed to get around to wrangling CMake, after breaking my backend upgrading LLVM.
I'll add a release for OSX soon for testing, but this is something we can potentially do for LDC releases when we ship with LLVM7.