MySQL driver #158

Closed
wants to merge 17 commits into
from

Conversation

Projects
None yet
6 participants
@yingted

yingted commented Sep 17, 2014

It looks like PostgreSQL is quite deeply intertwined with the db interface.

  • Move postgres to db and introduce a dialect (postgres or mysql) configuration.
  • Update docs.

yingted and others added some commits Jul 18, 2014

Merge branch 'master' of github.com:leafo/lapis
Conflicts:
	.travis.yml
	lapis/application.lua
	lapis/cache.lua
	lapis/cmd/actions.lua
	lapis/cmd/nginx.lua
	lapis/cmd/templates/app.lua
	lapis/cmd/templates/app_lua.lua
	lapis/cmd/templates/config.lua
	lapis/cmd/util.lua
	lapis/config.lua
	lapis/csrf.lua
	lapis/db/migrations.lua
	lapis/db/model.lua
	lapis/db/schema.lua
	lapis/features/etlua.lua
	lapis/html.lua
	lapis/init.lua
	lapis/logging.lua
	lapis/nginx.lua
	lapis/nginx/context.lua
	lapis/nginx/http.lua
	lapis/nginx/postgres.lua
	lapis/router.lua
	lapis/session.lua
	lapis/spec/request.lua
	lapis/spec/server.lua
	lapis/util.lua
	lapis/validate.lua
	lapis/version.lua
	lint_config.lua
@leafo

This comment has been minimized.

Show comment
Hide comment
@leafo

leafo Sep 17, 2014

Owner

Wow, quite the patch. I actually already started building mysql driver support, I'm assuming you came across that as you went through or are these changes on top of an older master?

I also noticed a lot of of the compiled Lua files seem to have gotten lost, no big deal I can recompile.

I'll need some time to go through this, thanks.

Owner

leafo commented Sep 17, 2014

Wow, quite the patch. I actually already started building mysql driver support, I'm assuming you came across that as you went through or are these changes on top of an older master?

I also noticed a lot of of the compiled Lua files seem to have gotten lost, no big deal I can recompile.

I'll need some time to go through this, thanks.

@yingted

This comment has been minimized.

Show comment
Hide comment
@yingted

yingted Sep 17, 2014

This branch is from around 2 months ago. I'm running it, but I forgot to open a PR.
Hmm, why are the compiled Lua files included in the source if they can be compiled?

yingted commented Sep 17, 2014

This branch is from around 2 months ago. I'm running it, but I forgot to open a PR.
Hmm, why are the compiled Lua files included in the source if they can be compiled?

@leafo

This comment has been minimized.

Show comment
Hide comment
@leafo

leafo Sep 17, 2014

Owner

When installing the module from source via luarocks there is no moonscript dependency so all the files need to be present.

I don't think luarocks has a good method for doing a compile step before installing lua files at the moment either.

Owner

leafo commented Sep 17, 2014

When installing the module from source via luarocks there is no moonscript dependency so all the files need to be present.

I don't think luarocks has a good method for doing a compile step before installing lua files at the moment either.

Merge branch 'master' into mysql
Conflicts:
	lapis/nginx/postgres.moon
@yingted

This comment has been minimized.

Show comment
Hide comment
@yingted

yingted Sep 17, 2014

Sorry, I didn't know about that. I reverted those changes.

yingted commented Sep 17, 2014

Sorry, I didn't know about that. I reverted those changes.

yingted added some commits Sep 17, 2014

Revert "fix dupes"
This reverts commit 920aa00.

Conflicts:
	lapis/cmd/actions.lua
	lapis/db/schema.lua
	lapis/nginx.lua
	lapis/nginx/postgres.lua
	lint_config.lua
+do
+ local _obj_0 = require("lapis.router")
+ Router = _obj_0.Router
+end

This comment has been minimized.

@yingted

yingted Sep 17, 2014

Not sure why my moonc does this.

@yingted

yingted Sep 17, 2014

Not sure why my moonc does this.

@@ -47,7 +47,7 @@ parse_multipart = ->
ngx_req = {
headers: -> ngx.req.get_headers!
cmd_mth: -> ngx.var.request_method
- cmd_url: -> ngx.var.request_uri

This comment has been minimized.

@yingted

yingted Sep 17, 2014

request_uri doesn't change when nginx rewrites requests

@yingted

yingted Sep 17, 2014

request_uri doesn't change when nginx rewrites requests

@neoascetic neoascetic referenced this pull request Oct 25, 2014

Open

Support MySQL #46

6 of 7 tasks complete
@CriztianiX

This comment has been minimized.

Show comment
Hide comment
@CriztianiX

CriztianiX Oct 30, 2014

Contributor

Trying to use this patch... i've had to add:

local config = require("lapis.config").get()

in lapis.nginx.db.lua line 166

Contributor

CriztianiX commented Oct 30, 2014

Trying to use this patch... i've had to add:

local config = require("lapis.config").get()

in lapis.nginx.db.lua line 166

@justicel

This comment has been minimized.

Show comment
Hide comment
@justicel

justicel Oct 30, 2014

Is there any word on this being merged or updated?

Is there any word on this being merged or updated?

@Xe

This comment has been minimized.

Show comment
Hide comment
@Xe

Xe Jan 5, 2015

+1 for this change

Xe commented Jan 5, 2015

+1 for this change

@leafo

This comment has been minimized.

Show comment
Hide comment
@leafo

leafo Feb 25, 2015

Owner

I decided not to use this patch since it was built on top of the pre-mysql version of lapis I started a while ago. I did resume mysql development here though: #46

Most of the functionality for mysql is already in master. The last major remaining component is support for models.

Owner

leafo commented Feb 25, 2015

I decided not to use this patch since it was built on top of the pre-mysql version of lapis I started a while ago. I did resume mysql development here though: #46

Most of the functionality for mysql is already in master. The last major remaining component is support for models.

@leafo leafo closed this Feb 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment