MySQL driver #158
MySQL driver #158
Conversation
Conflicts: .travis.yml lapis/application.lua lapis/cache.lua lapis/cmd/actions.lua lapis/cmd/nginx.lua lapis/cmd/templates/app.lua lapis/cmd/templates/app_lua.lua lapis/cmd/templates/config.lua lapis/cmd/util.lua lapis/config.lua lapis/csrf.lua lapis/db/migrations.lua lapis/db/model.lua lapis/db/schema.lua lapis/features/etlua.lua lapis/html.lua lapis/init.lua lapis/logging.lua lapis/nginx.lua lapis/nginx/context.lua lapis/nginx/http.lua lapis/nginx/postgres.lua lapis/router.lua lapis/session.lua lapis/spec/request.lua lapis/spec/server.lua lapis/util.lua lapis/validate.lua lapis/version.lua lint_config.lua
|
Wow, quite the patch. I actually already started building mysql driver support, I'm assuming you came across that as you went through or are these changes on top of an older master? I also noticed a lot of of the compiled Lua files seem to have gotten lost, no big deal I can recompile. I'll need some time to go through this, thanks. |
|
This branch is from around 2 months ago. I'm running it, but I forgot to open a PR. |
|
When installing the module from source via luarocks there is no moonscript dependency so all the files need to be present. I don't think luarocks has a good method for doing a compile step before installing lua files at the moment either. |
Conflicts: lapis/nginx/postgres.moon
|
Sorry, I didn't know about that. I reverted those changes. |
This reverts commit 920aa00. Conflicts: lapis/cmd/actions.lua lapis/db/schema.lua lapis/nginx.lua lapis/nginx/postgres.lua lint_config.lua
There was a problem hiding this comment.
Not sure why my moonc does this.
|
Trying to use this patch... i've had to add: local config = require("lapis.config").get() in lapis.nginx.db.lua line 166 |
|
Is there any word on this being merged or updated? |
|
+1 for this change |
|
I decided not to use this patch since it was built on top of the pre-mysql version of lapis I started a while ago. I did resume mysql development here though: #46 Most of the functionality for mysql is already in master. The last major remaining component is support for models. |
It looks like PostgreSQL is quite deeply intertwined with the
dbinterface.postgrestodband introduce a dialect (postgresormysql) configuration.