Fix -Wimplicit-function-declaration in md5.c and lam.c #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noticed that apart from |
Otherwise, causes a -Wimplicit-function-declaration warning. Other C sources which use b64_ntop include util.h.
and include in in lam.c (only user of this function so far). The same approach has been taken for reallocarray and this fixes a -Wimplicit-function-declaration warning.
|
So the idea is to use |
|
Fixed in 50877e1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upstreams a patch we had in Alpine downstream for a while.
This patch fixes two implicit function declaration warnings:
lam.cuses recallocarray fromrecallocarray.cfor which no function prototype was provided previously. Similar to reallocarray such a function prototype is now provided inutil.handlam.chas been modified to include this file.md5.cuses b64_ntop but, contrary to other users of this function (e.g. signify), does not includeutil.hwhich provides the function prototype for b64_ntop.Note that implicit function declarations can affect code generation so it would be cool to get this fixed upstream :)