PhpSpec 4 #10
PhpSpec 4 #10
Conversation
|
Is there any blocker for this PR to be merged? How can I help? |
| "php": "~5.6||~7.0", | ||
| "phpspec/phpspec": "~3.0", | ||
| "php": "^7.0", | ||
| "phpspec/phpspec": "^4.0", |
There was a problem hiding this comment.
What about "phpspec/phpspec": "~3.0||~4.0"?
There was a problem hiding this comment.
There are previous releases which already cater to PhpSpec 3 - maybe you could use those if you can't upgraded to PhpSpec 4?
There was a problem hiding this comment.
@Landerstraeten the update would be for PHPSpec v4. Allowing both versions would cause problems when people try to install updated version with 3.0 versions (and we can only make sure it's compatible with v4). After this PR is merged, the composer will be able to detect which version of phpspec-code-coverage to install depending on which PhpSpec version is used. For PhpSpec v3, the older version of the package that supports PhpSpec v3 will be used.
| @@ -24,12 +24,12 @@ | |||
| "docs": "https://github.com/leanphp/phpspec-code-coverage#phpspec-code-coverage" | |||
| }, | |||
| "require": { | |||
| "php": "~5.6||~7.0", | |||
There was a problem hiding this comment.
I think it should be kept like this
There was a problem hiding this comment.
The PR switches to PhpSpec 4, which only works in PHP 7
There was a problem hiding this comment.
The update is correct. For anyone, who will use PHP 5.x, the composer will use the older version of this package (the one before this PR is merged).
|
Hey there, any blockers on this? 😃 |
|
Any news about this P.R.? |
|
@Sam-Burns please check the comments on this pr... |
| @@ -22,7 +22,7 @@ package with compatible version numbers for stable releases. | |||
| - PHP 5.6+ or PHP 7+ | |||
| - [Xdebug][3] or [phpdbg][4] extension enabled (PHP 7+ is required for code | |||
| generation to work with [phpdbg][4]). | |||
| - [PhpSpec v3][2] | |||
| - [PhpSpec v3 or v4][2] | |||
There was a problem hiding this comment.
If composer.json file has this change:
- "phpspec/phpspec": "~3.0",
+ "phpspec/phpspec": "^4.0",
Then why do we need to keep PhpSpec v3?
There was a problem hiding this comment.
Looks like a good remark, I don't think we need this anymore
There was a problem hiding this comment.
The composer.json only refers to the latest version, which only supports phpspec 4.0. Composer will be able to pick up an older version of the package appropriately. For now, as long as PhpSpec3 is still used in various projects, I believe it is correct to note that extension supports both versions of PhpSpec.
| @@ -24,12 +24,12 @@ | |||
| "docs": "https://github.com/leanphp/phpspec-code-coverage#phpspec-code-coverage" | |||
| }, | |||
| "require": { | |||
| "php": "~5.6||~7.0", | |||
| "phpspec/phpspec": "~3.0", | |||
| "php": "^7.0", | |||
There was a problem hiding this comment.
Question: Is PHP 7.1 working with PHP Spec v4?
There was a problem hiding this comment.
Then I suggest to add it too, just to make sure it won't be a problem for some projects in case they have new criteria like the minimum PHP version
There was a problem hiding this comment.
The ^7.0 should be specific enough as it will allow any 7.x versions to be used. The ^ means not earlier version than.
|
Please do not forget my previous comment. |
|
I have reviewed the comments from everyone and I believe the changes should be good for merging. I will do some final tests and prepare separate branch for any maintenance for Thank you for contribution. |
|
Merging, thank you for contribution everyone! |
No description provided.