Skip to content

Commit 855a27b

Browse files
chore: move non @[to_additive] parts of Algebra.Order.Monoid and Algebra.Order.Group to a different file (#14667)
Following the discussion on #14598, move `LinearOrderedAddCommMonoidWithTop`, `LinearOrderedAddCommGroupWithTop`, and associated theorems to `Algebra.Order.AddGroupWithTop`. Co-authored-by: Daniel Weber <55664973+Command-Master@users.noreply.github.com>
1 parent 41eb6f9 commit 855a27b

File tree

16 files changed

+759
-756
lines changed

16 files changed

+759
-756
lines changed

Counterexamples/OrderedCancelAddCommMonoidWithBounds.lean

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
44
Authors: Martin Dvorak
55
-/
66
import Mathlib.Algebra.Order.Monoid.Defs
7+
import Mathlib.Order.BoundedOrder
78

89
/-!
910
# Do not combine OrderedCancelAddCommMonoid with BoundedOrder

Mathlib.lean

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -494,6 +494,7 @@ import Mathlib.Algebra.MvPolynomial.Variables
494494
import Mathlib.Algebra.NeZero
495495
import Mathlib.Algebra.Opposites
496496
import Mathlib.Algebra.Order.AbsoluteValue
497+
import Mathlib.Algebra.Order.AddGroupWithTop
497498
import Mathlib.Algebra.Order.AddTorsor
498499
import Mathlib.Algebra.Order.Algebra
499500
import Mathlib.Algebra.Order.Antidiag.Finsupp
@@ -546,7 +547,6 @@ import Mathlib.Algebra.Order.Group.Synonym
546547
import Mathlib.Algebra.Order.Group.TypeTags
547548
import Mathlib.Algebra.Order.Group.Unbundled.Basic
548549
import Mathlib.Algebra.Order.Group.Units
549-
import Mathlib.Algebra.Order.Group.WithTop
550550
import Mathlib.Algebra.Order.GroupWithZero.Canonical
551551
import Mathlib.Algebra.Order.GroupWithZero.Synonym
552552
import Mathlib.Algebra.Order.GroupWithZero.Unbundled

Mathlib/Algebra/CharZero/Lemmas.lean

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Authors: Mario Carneiro
55
-/
66
import Mathlib.Algebra.Group.Support
77
import Mathlib.Algebra.Order.Monoid.Unbundled.Pow
8-
import Mathlib.Algebra.Order.Monoid.WithTop
8+
import Mathlib.Algebra.Order.AddGroupWithTop
99
import Mathlib.Data.Nat.Cast.Field
1010
import Mathlib.Algebra.Field.Basic
1111

Mathlib/Algebra/Order/AddGroupWithTop.lean

Lines changed: 747 additions & 0 deletions
Large diffs are not rendered by default.

Mathlib/Algebra/Order/Group/Defs.lean

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -116,14 +116,6 @@ addition is monotone. -/
116116
class LinearOrderedAddCommGroup (α : Type u) extends OrderedAddCommGroup α, LinearOrder α
117117
#align linear_ordered_add_comm_group LinearOrderedAddCommGroup
118118

119-
/-- A linearly ordered commutative group with an additively absorbing `⊤` element.
120-
Instances should include number systems with an infinite element adjoined. -/
121-
class LinearOrderedAddCommGroupWithTop (α : Type*) extends LinearOrderedAddCommMonoidWithTop α,
122-
SubNegMonoid α, Nontrivial α where
123-
protected neg_top : -(⊤ : α) = ⊤
124-
protected add_neg_cancel : ∀ a : α, a ≠ ⊤ → a + -a = 0
125-
#align linear_ordered_add_comm_group_with_top LinearOrderedAddCommGroupWithTop
126-
127119
/-- A linearly ordered commutative group is a
128120
commutative group with a linear order in which
129121
multiplication is monotone. -/

Mathlib/Algebra/Order/Group/WithTop.lean

Lines changed: 0 additions & 86 deletions
This file was deleted.

Mathlib/Algebra/Order/GroupWithZero/Canonical.lean

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import Mathlib.Algebra.GroupWithZero.WithZero
1010
import Mathlib.Algebra.Order.Group.Units
1111
import Mathlib.Algebra.Order.GroupWithZero.Synonym
1212
import Mathlib.Algebra.Order.Monoid.Basic
13+
import Mathlib.Algebra.Order.AddGroupWithTop
1314
import Mathlib.Algebra.Order.Monoid.OrderDual
1415
import Mathlib.Algebra.Order.Monoid.TypeTags
1516
import Mathlib.Algebra.Order.ZeroLEOne

Mathlib/Algebra/Order/Monoid/Defs.lean

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ Released under Apache 2.0 license as described in the file LICENSE.
44
Authors: Jeremy Avigad, Leonardo de Moura, Mario Carneiro, Johannes Hölzl
55
-/
66
import Mathlib.Algebra.Order.Monoid.Unbundled.Basic
7-
import Mathlib.Order.BoundedOrder
87

98
#align_import algebra.order.monoid.defs from "leanprover-community/mathlib"@"70d50ecfd4900dd6d328da39ab7ebd516abe4025"
109

@@ -137,31 +136,6 @@ class LinearOrderedCancelCommMonoid (α : Type*) extends OrderedCancelCommMonoid
137136

138137
attribute [to_additive existing] LinearOrderedCancelCommMonoid.toLinearOrderedCommMonoid
139138

140-
/-- A linearly ordered commutative monoid with an additively absorbing `⊤` element.
141-
Instances should include number systems with an infinite element adjoined. -/
142-
class LinearOrderedAddCommMonoidWithTop (α : Type*) extends LinearOrderedAddCommMonoid α,
143-
OrderTop α where
144-
/-- In a `LinearOrderedAddCommMonoidWithTop`, the `⊤` element is invariant under addition. -/
145-
protected top_add' : ∀ x : α, ⊤ + x = ⊤
146-
#align linear_ordered_add_comm_monoid_with_top LinearOrderedAddCommMonoidWithTop
147-
#align linear_ordered_add_comm_monoid_with_top.to_order_top LinearOrderedAddCommMonoidWithTop.toOrderTop
148-
149-
section LinearOrderedAddCommMonoidWithTop
150-
151-
variable [LinearOrderedAddCommMonoidWithTop α] {a b : α}
152-
153-
@[simp]
154-
theorem top_add (a : α) : ⊤ + a = ⊤ :=
155-
LinearOrderedAddCommMonoidWithTop.top_add' a
156-
#align top_add top_add
157-
158-
@[simp]
159-
theorem add_top (a : α) : a + ⊤ = ⊤ :=
160-
Trans.trans (add_comm _ _) (top_add _)
161-
#align add_top add_top
162-
163-
end LinearOrderedAddCommMonoidWithTop
164-
165139
variable [LinearOrderedCommMonoid α] {a : α}
166140

167141
@[to_additive (attr := simp)]

0 commit comments

Comments
 (0)