Skip to content

Commit d7c3d1e

Browse files
committed
chore(Algebra/Order/Module/Defs): don't import fields (#25584)
Instead move the few `Field` lemmas to a new file `Algebra.Order.Module.Field` (leanprover-community/mathlib3#9077 for the copyright) and the `positivity` extension to `Tactic.Positivity.Basic`.
1 parent 5b77ef3 commit d7c3d1e

35 files changed

+184
-152
lines changed

Archive/Wiedijk100Theorems/InverseTriangleSum.lean

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ Authors: Jalex Stark, Yury Kudryashov
66
import Mathlib.Algebra.BigOperators.Group.Finset.Powerset
77
import Mathlib.Data.Real.Basic
88
import Mathlib.Tactic.FieldSimp
9+
import Mathlib.Tactic.Positivity.Basic
910
import Mathlib.Tactic.Ring
1011

1112
/-!

Mathlib.lean

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -852,6 +852,7 @@ import Mathlib.Algebra.Order.Invertible
852852
import Mathlib.Algebra.Order.Kleene
853853
import Mathlib.Algebra.Order.Module.Algebra
854854
import Mathlib.Algebra.Order.Module.Defs
855+
import Mathlib.Algebra.Order.Module.Field
855856
import Mathlib.Algebra.Order.Module.OrderedSMul
856857
import Mathlib.Algebra.Order.Module.Pointwise
857858
import Mathlib.Algebra.Order.Module.PositiveLinearMap

Mathlib/Algebra/GeomSum.lean

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,13 @@ Authors: Neil Strickland
55
-/
66
import Mathlib.Algebra.BigOperators.Intervals
77
import Mathlib.Algebra.BigOperators.Ring.Finset
8+
import Mathlib.Algebra.Field.Basic
89
import Mathlib.Algebra.Group.NatPowAssoc
9-
import Mathlib.Algebra.Order.BigOperators.Ring.Finset
10+
import Mathlib.Algebra.Order.BigOperators.Group.Finset
1011
import Mathlib.Algebra.Ring.Opposite
11-
import Mathlib.Tactic.Abel
1212
import Mathlib.Algebra.Ring.Regular
13+
import Mathlib.Tactic.Abel
14+
import Mathlib.Tactic.Positivity.Basic
1315

1416
/-!
1517
# Partial sums of geometric series
@@ -427,7 +429,7 @@ theorem Nat.pred_mul_geom_sum_le (a b n : ℕ) :
427429
calc
428430
((b - 1) * ∑ i ∈ range n.succ, a / b ^ i) =
429431
(∑ i ∈ range n, a / b ^ (i + 1) * b) + a * b - ((∑ i ∈ range n, a / b ^ i) + a / b ^ n) := by
430-
rw [tsub_mul, mul_comm, sum_mul, one_mul, sum_range_succ', sum_range_succ, pow_zero,
432+
rw [Nat.sub_mul, mul_comm, sum_mul, one_mul, sum_range_succ', sum_range_succ, pow_zero,
431433
Nat.div_one]
432434
_ ≤ (∑ i ∈ range n, a / b ^ i) + a * b - ((∑ i ∈ range n, a / b ^ i) + a / b ^ n) := by
433435
gcongr with i hi

Mathlib/Algebra/MvPolynomial/Degrees.lean

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -475,8 +475,8 @@ lemma totalDegree_finsetSum_le {ι : Type*} {s : Finset ι} {f : ι → MvPolyno
475475
(totalDegree_finset_sum ..).trans <| Finset.sup_le hf
476476

477477
lemma degreeOf_le_totalDegree (f : MvPolynomial σ R) (i : σ) : f.degreeOf i ≤ f.totalDegree :=
478-
degreeOf_le_iff.mpr fun d hd ↦ (eq_or_ne (d i) 0).elim (·.trans_le zero_le') fun h ↦
479-
(Finset.single_le_sum (fun _ _ ↦ zero_le') <| Finsupp.mem_support_iff.mpr h).trans
478+
degreeOf_le_iff.mpr fun d hd ↦ (eq_or_ne (d i) 0).elim (by omega) fun h ↦
479+
(Finset.single_le_sum (by omega) <| Finsupp.mem_support_iff.mpr h).trans
480480
(le_totalDegree hd)
481481

482482
theorem exists_degree_lt [Fintype σ] (f : MvPolynomial σ R) (n : ℕ)

Mathlib/Algebra/MvPolynomial/SchwartzZippel.lean

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@ Authors: Bolton Bailey, Yaël Dillies, Andrew Yang
66
import Mathlib.Algebra.BigOperators.Field
77
import Mathlib.Algebra.MvPolynomial.Equiv
88
import Mathlib.Algebra.MvPolynomial.Variables
9-
import Mathlib.Algebra.Order.Group.Finset
109
import Mathlib.Algebra.Order.GroupWithZero.Finset
1110
import Mathlib.Algebra.Order.Ring.Finset
1211
import Mathlib.Algebra.Polynomial.Roots
1312
import Mathlib.Data.Fin.Tuple.Finset
1413
import Mathlib.Tactic.Positivity.Finset
14+
import Mathlib.Tactic.GCongr
1515

1616
/-!
1717
# The Schwartz-Zippel lemma

Mathlib/Algebra/Order/AbsoluteValue/Basic.lean

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import Mathlib.Algebra.GroupWithZero.Units.Lemmas
77
import Mathlib.Algebra.Order.Hom.Basic
88
import Mathlib.Algebra.Order.Ring.Abs
99
import Mathlib.Algebra.Regular.Basic
10-
import Mathlib.Tactic.Bound.Attribute
10+
import Mathlib.Tactic.Positivity.Core
1111

1212
/-!
1313
# Absolute values

Mathlib/Algebra/Order/BigOperators/Expect.lean

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@ Authors: Yaël Dillies
66
import Mathlib.Algebra.BigOperators.Expect
77
import Mathlib.Algebra.Module.Rat
88
import Mathlib.Algebra.Order.BigOperators.Ring.Finset
9+
import Mathlib.Algebra.Order.Module.Field
910
import Mathlib.Algebra.Order.Module.Rat
11+
import Mathlib.Tactic.GCongr
1012

1113
/-!
1214
# Order properties of the average over a finset

Mathlib/Algebra/Order/CauSeq/Basic.lean

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ This is a concrete implementation that is useful for simplicity and computabilit
3131
sequence, cauchy, abs val, absolute value
3232
-/
3333

34-
assert_not_exists Finset Module Submonoid FloorRing Module
34+
assert_not_exists Finset Module Submonoid FloorRing
3535

3636
variable {α β : Type*}
3737

@@ -76,6 +76,7 @@ theorem rat_inv_continuous_lemma {β : Type*} [DivisionRing β] (abv : β → α
7676
rw [mul_assoc, inv_mul_cancel_right₀ b0.ne', ← mul_assoc, mul_inv_cancel₀ a0.ne', one_mul]
7777
refine h.trans_le ?_
7878
gcongr
79+
exact mul_nonneg a0.le ε0.le
7980

8081
end
8182

Mathlib/Algebra/Order/CauSeq/BigOperators.lean

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ Authors: Chris Hughes, Yaël Dillies
55
-/
66
import Mathlib.Algebra.GeomSum
77
import Mathlib.Algebra.Order.Archimedean.Basic
8+
import Mathlib.Algebra.Order.BigOperators.Ring.Finset
89
import Mathlib.Algebra.Order.CauSeq.Basic
910

1011
/-!

Mathlib/Algebra/Order/Floor/Div.lean

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ Released under Apache 2.0 license as described in the file LICENSE.
44
Authors: Yaël Dillies
55
-/
66
import Mathlib.Algebra.GroupWithZero.Action.Pi
7-
import Mathlib.Algebra.Order.Module.Defs
8-
import Mathlib.Algebra.Order.Pi
97
import Mathlib.Data.Finsupp.Order
108

119
/-!

0 commit comments

Comments
 (0)