Skip to content

Commit f1308d7

Browse files
committed
refactor: Turn Freiman homs into predicates (#12546)
The bundled hom approach to Freiman homomorphisms is a fail. It is very hard to use and doesn't bring anything. That is because Freiman homs don't have much structure and we do not study them under this angle. This PR replaces the bundled homs by predicates and moves the file from `Algebra.Group.Freiman` to `Combinatorics.Additive.FreimanHom` so that: * It is clear these are combinatorial objects, not algebraic ones. * The diff isn't completely mangled. Nothing was kept so it's not worth comparing via a naïve git diff. Also fix a few oddities accidentally introduced in #12701.
1 parent 838141a commit f1308d7

File tree

5 files changed

+455
-585
lines changed

5 files changed

+455
-585
lines changed

Mathlib.lean

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,6 @@ import Mathlib.Algebra.Group.Embedding
200200
import Mathlib.Algebra.Group.Equiv.Basic
201201
import Mathlib.Algebra.Group.Equiv.TypeTags
202202
import Mathlib.Algebra.Group.Ext
203-
import Mathlib.Algebra.Group.Freiman
204203
import Mathlib.Algebra.Group.Hom.Basic
205204
import Mathlib.Algebra.Group.Hom.CompTypeclasses
206205
import Mathlib.Algebra.Group.Hom.Defs
@@ -1602,6 +1601,7 @@ import Mathlib.Combinatorics.Additive.AP.Three.Behrend
16021601
import Mathlib.Combinatorics.Additive.AP.Three.Defs
16031602
import Mathlib.Combinatorics.Additive.ETransform
16041603
import Mathlib.Combinatorics.Additive.Energy
1604+
import Mathlib.Combinatorics.Additive.FreimanHom
16051605
import Mathlib.Combinatorics.Additive.PluenneckeRuzsa
16061606
import Mathlib.Combinatorics.Additive.RuzsaCovering
16071607
import Mathlib.Combinatorics.Colex

0 commit comments

Comments
 (0)