Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting note: broken dot notation #11036

Open
pitmonticone opened this issue Feb 28, 2024 · 0 comments
Open

Porting note: broken dot notation #11036

pitmonticone opened this issue Feb 28, 2024 · 0 comments
Labels
porting-notes Mathlib3 to Mathlib4 porting notes.

Comments

@pitmonticone
Copy link
Collaborator

pitmonticone commented Feb 28, 2024

Classifies porting notes claiming anything equivalent to

  • "broken dot notation"
  • "dot notation no longer works"

Examples

/-- The categorical kernel of a morphism in `ModuleCat`
agrees with the usual module-theoretical kernel.
-/
noncomputable def kernelIsoKer {G H : ModuleCat.{v} R} (f : G ⟶ H) :
-- Porting note: broken dot notation
kernel f ≅ ModuleCat.of R (LinearMap.ker f) :=
limit.isoLimitCone ⟨_, kernelIsLimit f⟩
#align Module.kernel_iso_ker ModuleCat.kernelIsoKer

/-- The natural isomorphism from the dual of a subspace `W` to `W.dualLift.range`. -/
-- Porting note: broken dot notation lean4#1910 LinearMap.range
noncomputable def dualEquivDual (W : Subspace K V) :
Module.Dual K W ≃ₗ[K] LinearMap.range W.dualLift :=
LinearEquiv.ofInjective _ dualLift_injective
#align subspace.dual_equiv_dual Subspace.dualEquivDual

-- Porting note: dot notation no longer works
@[simp]
protected theorem down_up (s : Set α) : SetSemiring.down (Set.up s) = s :=
rfl
#align set_semiring.down_up SetSemiring.down_up
-- Porting note: dot notation no longer works
@[simp]
protected theorem up_down (s : SetSemiring α) : Set.up (SetSemiring.down s) = s :=
rfl
#align set_semiring.up_down SetSemiring.up_down
-- TODO: These lemmas are not tagged `simp` because `Set.le_eq_subset` simplifies the LHS
-- Porting note: dot notation no longer works
theorem up_le_up {s t : Set α} : Set.up s ≤ Set.up t ↔ s ⊆ t :=
Iff.rfl
#align set_semiring.up_le_up SetSemiring.up_le_up
-- Porting note: dot notation no longer works
theorem up_lt_up {s t : Set α} : Set.up s < Set.up t ↔ s ⊂ t :=
Iff.rfl
#align set_semiring.up_lt_up SetSemiring.up_lt_up
-- Porting note: dot notation no longer works
@[simp]
theorem down_subset_down {s t : SetSemiring α} : SetSemiring.down s ⊆ SetSemiring.down t ↔ s ≤ t :=
Iff.rfl
#align set_semiring.down_subset_down SetSemiring.down_subset_down
-- Porting note: dot notation no longer works
@[simp]
theorem down_ssubset_down {s t : SetSemiring α} : SetSemiring.down s ⊂ SetSemiring.down t ↔ s < t :=
Iff.rfl
#align set_semiring.down_ssubset_down SetSemiring.down_ssubset_down

@pitmonticone pitmonticone added the porting-notes Mathlib3 to Mathlib4 porting notes. label Feb 28, 2024
mathlib-bors bot pushed a commit that referenced this issue Feb 28, 2024
Classifies by adding issue number #11036 to porting notes claiming: 

> broken dot notation
mathlib-bors bot pushed a commit that referenced this issue Feb 28, 2024
Classifies by adding issue number #11036 to porting notes claiming: 

> broken dot notation
riccardobrasca pushed a commit that referenced this issue Mar 1, 2024
Classifies by adding issue number #11036 to porting notes claiming: 

> broken dot notation
kbuzzard pushed a commit that referenced this issue Mar 12, 2024
Classifies by adding issue number #11036 to porting notes claiming: 

> broken dot notation
mathlib-bors bot pushed a commit that referenced this issue Mar 16, 2024
Classifies by adding issue number #11036 to porting notes claiming: 

> dot notation no longer works
dagurtomas pushed a commit that referenced this issue Mar 22, 2024
Classifies by adding issue number #11036 to porting notes claiming: 

> broken dot notation
dagurtomas pushed a commit that referenced this issue Mar 22, 2024
Classifies by adding issue number #11036 to porting notes claiming: 

> dot notation no longer works
utensil pushed a commit that referenced this issue Mar 26, 2024
Classifies by adding issue number #11036 to porting notes claiming: 

> dot notation no longer works
Louddy pushed a commit that referenced this issue Apr 15, 2024
Classifies by adding issue number #11036 to porting notes claiming: 

> broken dot notation
Louddy pushed a commit that referenced this issue Apr 15, 2024
Classifies by adding issue number #11036 to porting notes claiming: 

> dot notation no longer works
atarnoam pushed a commit that referenced this issue Apr 16, 2024
Classifies by adding issue number #11036 to porting notes claiming: 

> dot notation no longer works
uniwuni pushed a commit that referenced this issue Apr 19, 2024
Classifies by adding issue number #11036 to porting notes claiming: 

> dot notation no longer works
callesonne pushed a commit that referenced this issue Apr 22, 2024
Classifies by adding issue number #11036 to porting notes claiming: 

> dot notation no longer works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
porting-notes Mathlib3 to Mathlib4 porting notes.
Projects
None yet
Development

No branches or pull requests

1 participant