Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(RingTheory/MvPolynomial/Homogeneous): misc lemmas on homogeneous polyomials #10478

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(RingTheory/MvPolynomial/Homogeneous): misc lemmas on homogeneous polyomials #10478

wants to merge 2 commits into from

Conversation

jcommelin
Copy link
Member

Open in Gitpod

@jcommelin @github-actions
Update Mathlib/RingTheory/MvPolynomial/Homogeneous.lean
98829ae 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@adomani
Copy link
Collaborator

adomani commented Feb 13, 2024

LGTM!

I only have two doubts.

  • Should lemmas like 
    theorem natCast (n : ℕ) : (n : MvPolynomial σ R).IsHomogeneous 0 :=
isHomogeneous_C ..
    be added? Note that exact? does not close the goal.
  • Why is there almost no lemma in this file tagged as simp?

@ocfnash
Copy link
Contributor

ocfnash commented Feb 14, 2024

I agree with @adomani 's remarks but I don't think they need to block merging these results.

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Feb 14, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 14, 2024
@jcommelin
chore(RingTheory/MvPolynomial/Homogeneous): misc lemmas on homogeneou…
4fe12e0 
…s polyomials (#10478)
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 14, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(RingTheory/MvPolynomial/Homogeneous): misc lemmas on homogeneous polyomials [Merged by Bors] - chore(RingTheory/MvPolynomial/Homogeneous): misc lemmas on homogeneous polyomials Feb 14, 2024
@mathlib-bors mathlib-bors bot closed this Feb 14, 2024
@mathlib-bors mathlib-bors bot deleted the homogeneous-misc branch February 14, 2024 23:28
riccardobrasca pushed a commit that referenced this pull request Feb 18, 2024
@jcommelin @riccardobrasca
chore(RingTheory/MvPolynomial/Homogeneous): misc lemmas on homogeneou…
1c32703 
…s polyomials (#10478)
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@jcommelin @dagurtomas
chore(RingTheory/MvPolynomial/Homogeneous): misc lemmas on homogeneou…
6c5ccf6 
…s polyomials (#10478)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@adomani adomani adomani approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcommelin @adomani @ocfnash