Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: more backporting of simp changes from #10995 #11001

Closed
wants to merge 5 commits into from

Conversation

kim-em
Copy link
Contributor

@kim-em kim-em commented Feb 27, 2024

No description provided.

@kim-em kim-em changed the title chore: more back of simp changes from #10995 chore: more backporting of simp changes from #10995 Feb 27, 2024
@jcommelin
Copy link
Member

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 27, 2024

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@kim-em kim-em added auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. and removed awaiting-CI labels Feb 27, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

As this PR is labelled auto-merge-after-CI, we are now sending it to bors:

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Feb 27, 2024
Co-authored-by: Patrick Massot <patrickmassot@free.fr>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 27, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: more backporting of simp changes from #10995 [Merged by Bors] - chore: more backporting of simp changes from #10995 Feb 27, 2024
@mathlib-bors mathlib-bors bot closed this Feb 27, 2024
@mathlib-bors mathlib-bors bot deleted the pm_simp2 branch February 27, 2024 10:02
mathlib-bors bot pushed a commit that referenced this pull request Mar 1, 2024
A random collection of changes, backporting from the upcoming Lean bump.
- squeeze one simp
- backport one more simp change (which probably was missed in the previous backports)
- rewrite the `field_simp` in SolutionOfCubic: with the upcoming Lean bump, this would become **very** slow

Similar to #10996 and #11001.
riccardobrasca pushed a commit that referenced this pull request Mar 1, 2024
Co-authored-by: Patrick Massot <patrickmassot@free.fr>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
riccardobrasca pushed a commit that referenced this pull request Mar 1, 2024
A random collection of changes, backporting from the upcoming Lean bump.
- squeeze one simp
- backport one more simp change (which probably was missed in the previous backports)
- rewrite the `field_simp` in SolutionOfCubic: with the upcoming Lean bump, this would become **very** slow

Similar to #10996 and #11001.
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
Co-authored-by: Patrick Massot <patrickmassot@free.fr>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
A random collection of changes, backporting from the upcoming Lean bump.
- squeeze one simp
- backport one more simp change (which probably was missed in the previous backports)
- rewrite the `field_simp` in SolutionOfCubic: with the upcoming Lean bump, this would become **very** slow

Similar to #10996 and #11001.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Co-authored-by: Patrick Massot <patrickmassot@free.fr>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
A random collection of changes, backporting from the upcoming Lean bump.
- squeeze one simp
- backport one more simp change (which probably was missed in the previous backports)
- rewrite the `field_simp` in SolutionOfCubic: with the upcoming Lean bump, this would become **very** slow

Similar to #10996 and #11001.
utensil pushed a commit that referenced this pull request Mar 26, 2024
A random collection of changes, backporting from the upcoming Lean bump.
- squeeze one simp
- backport one more simp change (which probably was missed in the previous backports)
- rewrite the `field_simp` in SolutionOfCubic: with the upcoming Lean bump, this would become **very** slow

Similar to #10996 and #11001.
Louddy pushed a commit that referenced this pull request Apr 15, 2024
Co-authored-by: Patrick Massot <patrickmassot@free.fr>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Louddy pushed a commit that referenced this pull request Apr 15, 2024
A random collection of changes, backporting from the upcoming Lean bump.
- squeeze one simp
- backport one more simp change (which probably was missed in the previous backports)
- rewrite the `field_simp` in SolutionOfCubic: with the upcoming Lean bump, this would become **very** slow

Similar to #10996 and #11001.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. delegated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants