[Merged by Bors] - chore(DirectSum): drop a DecidableEq assumption
#11537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
urkud
commented
Mar 20, 2024
urkud
commented
urkud
added
awaiting-review
easy
sgouezel
reviewed
Mar 21, 2024
| namespace LinearMap | ||
|
|
||
| variable {ι R M : Type*} [CommRing R] [AddCommGroup M] [Module R M] {N : ι → Submodule R M} | ||
|
|
||
| section IsInternal |
There was a problem hiding this comment.
The name is not very clear (because internal has a mathematical meaning). Maybe AuxiliaryConstruction or just Auxiliary?
There was a problem hiding this comment.
This section has variable (h : IsInternal N).
There was a problem hiding this comment.
Oh yeah. So the name is fine. I'd rather have h moved to the various lemmas to make them more readable, but it's not really in scope for this PR. So you can merge!
|
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors merge |
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
DecidableEq assumptionDecidableEq assumption
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.