Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor: move theorem about lists to batteries #12540

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - refactor: move theorem about lists to batteries #12540

wants to merge 4 commits into from

Conversation

chabulhwi
Copy link
Collaborator

@chabulhwi chabulhwi commented Apr 30, 2024 •
edited by github-actions bot
Loading

List.modifyHead_modifyHead is from Mathlib.Data.List.Basic. I need
it to prove String.splitOn_of_valid. See
leanprover-community/batteries#743.

Corresponding Batteries PR:
leanprover-community/batteries#756

@chabulhwi chabulhwi self-assigned this Apr 30, 2024
@chabulhwi chabulhwi added blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) blocked-by-batt-PR This PR depends on a PR to Batteries labels Apr 30, 2024
@chabulhwi chabulhwi mentioned this pull request Apr 30, 2024
Merged
1 task
@chabulhwi chabulhwi added the dependency-bump This PR bumps the version of an upstream dependency (but not toolchain). label May 6, 2024
@chabulhwi chabulhwi changed the title refactor: move theorems about lists to std refactor: move theorems about lists to batteries May 7, 2024
@chabulhwi chabulhwi force-pushed the chabulhwi/list-theorems branch 4 times, most recently from a9f7bb7 to cd6d973 Compare May 10, 2024 01:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 8, 2024 •
edited
Loading

PR summary 3281554ac4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

- isEmpty_iff_eq_nil
- modifyHead_modifyHead
- subperm_nil

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 20, 2024
chabulhwi added a commit to chabulhwi/batteries that referenced this pull request Sep 3, 2024
@chabulhwi @kim-em
refactor: move theorems about lists from mathlib
b6a0c53 
`List.isEmpty_iff_eq_nil` and `List.modifyHead_modifyHead` are from
`Mathlib.Data.List.Basic`. We need these theorems to prove
`String.splitOn_of_valid`. See
leanprover-community#743.

Batteries bump PR in Mathlib: leanprover-community/mathlib4#12540

Co-authored-by: Kim Morrison <kim@tqft.net>
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 3, 2024
chabulhwi added a commit to chabulhwi/batteries that referenced this pull request Sep 3, 2024
@chabulhwi @kim-em
refactor: move theorems about lists from mathlib
f6e0091 
`List.isEmpty_iff_eq_nil` and `List.modifyHead_modifyHead` are from
`Mathlib.Data.List.Basic`. We need these theorems to prove
`String.splitOn_of_valid`. See
leanprover-community#743.

Batteries bump PR in Mathlib: leanprover-community/mathlib4#12540

Co-authored-by: Kim Morrison <kim@tqft.net>
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 3, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Oct 14, 2024
@chabulhwi chabulhwi changed the title refactor: move theorems about lists to batteries refactor: move theorem about lists to batteries Oct 14, 2024
@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Oct 14, 2024
@chabulhwi chabulhwi removed the blocked-by-batt-PR This PR depends on a PR to Batteries label Oct 14, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 14, 2024
@chabulhwi
chore: bump batteries
8b0815e
@chabulhwi
refactor: move theorem about lists to batteries
2ea88b1 
`List.modifyHead_modifyHead` is from `Mathlib.Data.List.Basic`. I need
it to prove `String.splitOn_of_valid`. See
leanprover-community/batteries#743.

Corresponding Batteries PR:
leanprover-community/batteries#756
@kim-em
Copy link
Contributor

kim-em commented Oct 14, 2024

bors merge

@kim-em
Copy link
Contributor

kim-em commented Oct 14, 2024

bors p=10

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 14, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 14, 2024
@chabulhwi @kim-em
refactor: move theorem about lists to batteries (#12540)
8142938 
`List.modifyHead_modifyHead` is from `Mathlib.Data.List.Basic`. I need
it to prove `String.splitOn_of_valid`. See
leanprover-community/batteries#743.

Corresponding Batteries PR:
leanprover-community/batteries#756



Co-authored-by: Kim Morrison <kim@tqft.net>
@chabulhwi chabulhwi mentioned this pull request Oct 14, 2024
Closed
@mathlib4-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 14, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor: move theorem about lists to batteries [Merged by Bors] - refactor: move theorem about lists to batteries Oct 14, 2024
@mathlib-bors mathlib-bors bot closed this Oct 14, 2024
@mathlib-bors mathlib-bors bot deleted the chabulhwi/list-theorems branch October 14, 2024 08:17
@Ruben-VandeVelde Ruben-VandeVelde mentioned this pull request Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chabulhwi chabulhwi

Labels
dependency-bump This PR bumps the version of an upstream dependency (but not toolchain). ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chabulhwi @kim-em @mathlib4-dependent-issues-bot @YaelDillies @leanprover-community-bot-assistant @leanprover-community-mathlib4-bot