refactor: move theorems about lists to batteries #12540
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chabulhwi
added
blocked-by-other-PR
|
This PR/issue depends on:
|
1 task
chabulhwi
force-pushed
the
chabulhwi/list-theorems
branch
from
f1d64b0
to
c627472
Compare
chabulhwi
added
the
dependency-bump
chabulhwi
changed the title
chabulhwi
force-pushed
the
chabulhwi/list-theorems
branch
4 times, most recently
from
a9f7bb7
to
cd6d973
Compare
chabulhwi
force-pushed
the
chabulhwi/list-theorems
branch
from
cd6d973
to
2c43a0a
Compare
PR summaryImport changesNo significant changes to the import graph Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
* `List.isEmpty_iff_eq_nil` and `List.modifyHead_modifyHead` are from `Mathlib.Data.List.Basic`. I removed the `simp` priority and `nolint` attribute from `modifyHead_modifyHead` because we don't need them anymore. * `List.cons_prefix_cons` is from `Mathlib.Data.List.Infix`. Its previous name was `List.cons_prefix_iff`. We need these theorems to prove `String.splitOn_of_valid`. See leanprover-community/batteries#756.
Use `List.cons_prefix_cons` instead of `List.cons_prefix_iff`.
chabulhwi
force-pushed
the
chabulhwi/list-theorems
branch
from
2c43a0a
to
4fcf5e4
Compare
leanprover-community-mathlib4-bot
added
the
merge-conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List.isEmpty_iff_eq_nilandList.modifyHead_modifyHeadare fromMathlib.Data.List.Basic. I removed thesimppriority andnolintattribute from
modifyHead_modifyHeadbecause we don't need themanymore.
List.cons_prefix_consis fromMathlib.Data.List.Infix. Itsprevious name was
List.cons_prefix_iff. I replaced the deprecatedname with the new one.
We need these theorems to prove
String.splitOn_of_valid. Seeleanprover-community/batteries#756.