Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Data/Fin/Tuple/Basic): Fill in the API hole (partly) #13568

Closed
wants to merge 2 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Jun 6, 2024

As explained by the module doc, we are missing the Fin.succAbove equivalent of Fin.tail/Fin.init. In fact, it already exists as the second projection of extractNth, so this PR deletes extractNth and defines its second projection as a new function removeNth.


Open in Gitpod

@YaelDillies YaelDillies added blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) awaiting-review labels Jun 6, 2024
@YaelDillies YaelDillies changed the title chore(Fin/Tuple/Basic): Fill in the API hole (partly) chore(Data/Fin/Tuple/Basic): Fill in the API hole (partly) Jun 6, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jun 19, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Copy link

github-actions bot commented Jun 19, 2024

PR summary cd19a39d7f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ insertNth_removeNth
+ insertNth_self_removeNth
+ removeNth
+ removeNth_insertNth
+ removeNth_last
+ removeNth_update
+ removeNth_zero
- extractNth_insertNth
- insertNth_extractNth

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

As explained by the module doc, we are missing the `Fin.succAbove` equivalent of `Fin.tail`/`Fin.init`. In fact, it already exists as the second projection of `extractNth`, so this PR deletes `extractNth` and defines its second projection as a new function `removeNth`.
@eric-wieser
Copy link
Member

bors merge

Thanks!

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 11, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 11, 2024
As explained by the module doc, we are missing the `Fin.succAbove` equivalent of `Fin.tail`/`Fin.init`. In fact, it already exists as the second projection of `extractNth`, so this PR deletes `extractNth` and defines its second projection as a new function `removeNth`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 11, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Data/Fin/Tuple/Basic): Fill in the API hole (partly) [Merged by Bors] - chore(Data/Fin/Tuple/Basic): Fill in the API hole (partly) Jul 11, 2024
@mathlib-bors mathlib-bors bot closed this Jul 11, 2024
@mathlib-bors mathlib-bors bot deleted the fin_tuple_remove_nth branch July 11, 2024 21:21
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants