-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(Data/Fin/Tuple/Basic): Fill in the API hole (partly) #13568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
blocked-by-other-PR
This PR depends on another PR to Mathlib (this label is automatically managed by a bot)
awaiting-review
labels
Jun 6, 2024
4 tasks
YaelDillies
changed the title
chore(Fin/Tuple/Basic): Fill in the API hole (partly)
chore(Data/Fin/Tuple/Basic): Fill in the API hole (partly)
Jun 6, 2024
leanprover-community-mathlib4-bot
removed
the
blocked-by-other-PR
This PR depends on another PR to Mathlib (this label is automatically managed by a bot)
label
Jun 19, 2024
This PR/issue depends on: |
YaelDillies
force-pushed
the
fin_tuple_remove_nth
branch
from
June 19, 2024 10:49
0a77e11
to
e6677cc
Compare
PR summary cd19a39d7fImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
b-mehta
reviewed
Jun 24, 2024
eric-wieser
reviewed
Jul 11, 2024
eric-wieser
reviewed
Jul 11, 2024
As explained by the module doc, we are missing the `Fin.succAbove` equivalent of `Fin.tail`/`Fin.init`. In fact, it already exists as the second projection of `extractNth`, so this PR deletes `extractNth` and defines its second projection as a new function `removeNth`.
YaelDillies
force-pushed
the
fin_tuple_remove_nth
branch
from
July 11, 2024 20:00
cee648d
to
cd19a39
Compare
bors merge Thanks! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
As explained by the module doc, we are missing the `Fin.succAbove` equivalent of `Fin.tail`/`Fin.init`. In fact, it already exists as the second projection of `extractNth`, so this PR deletes `extractNth` and defines its second projection as a new function `removeNth`.
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
chore(Data/Fin/Tuple/Basic): Fill in the API hole (partly)
[Merged by Bors] - chore(Data/Fin/Tuple/Basic): Fill in the API hole (partly)
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained by the module doc, we are missing the
Fin.succAbove
equivalent ofFin.tail
/Fin.init
. In fact, it already exists as the second projection ofextractNth
, so this PR deletesextractNth
and defines its second projection as a new functionremoveNth
.