[Merged by Bors] - rename: no_lost_declarations to declarations_diff and short as default option
#14105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary 01cceba7e3Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> |
…larations_to_decl_diff
|
Looks reasonable! What do you think about renaming to |
adomani
changed the title
no_lost_declarations to decls_diff and short as default optionno_lost_declarations to declarations_diff and short as default option
|
Michael, thank you for the suggestion: I like it and I renamed the script to |
|
Thanks! |
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
grunweg
added
CI
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
…default option (#14105) This PR renames the `no_lost_declarations` script to `declarations_diff`, to better describe the effect of the script. It was originally intended as a script to make sure that "moving" PRs did not leave out any declaration, but is now used as a measure of the diff in declarations between PRs and master. The other change it does is to make the `short` option the default, as this is the most commonly used. |Old|New| |-|-| |`./scripts/no_lost_declarations.sh short`|`./scripts/declarations_diff.sh`| |`./scripts/no_lost_declarations.sh`|`./scripts/declarations_diff.sh long`| Mostly, these changes are invisible, as this script is used almost exclusively by CI, but the intention is that the change conveys better what script does to a human.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
no_lost_declarations to declarations_diff and short as default optionno_lost_declarations to declarations_diff and short as default option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the
no_lost_declarationsscript todeclarations_diff, to better describe the effect of the script. It was originally intended as a script to make sure that "moving" PRs did not leave out any declaration, but is now used as a measure of the diff in declarations between PRs and master.The other change it does is to make the
shortoption the default, as this is the most commonly used../scripts/no_lost_declarations.sh short./scripts/declarations_diff.sh./scripts/no_lost_declarations.sh./scripts/declarations_diff.sh longMostly, these changes are invisible, as this script is used almost exclusively by CI, but the intention is that the change conveys better what script does to a human.