-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: deprecate AlgHom.map_* lemmas #14168
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary c3e665ad07Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Ruben-VandeVelde
added
the
tech debt
Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
label
Jul 1, 2024
leanprover-community-mathlib4-bot
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Jul 9, 2024
These are redundant.
Ruben-VandeVelde
force-pushed
the
AlgHom-map
branch
from
July 10, 2024 08:07
a2a634d
to
c3e665a
Compare
leanprover-community-mathlib4-bot
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot)
label
Jul 10, 2024
jcommelin
reviewed
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
leanprover-community-mathlib4-bot
added
the
ready-to-merge
This PR has been sent to bors.
label
Jul 10, 2024
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
These are redundant. Unfortunately there's two cases involving `GradedAlgebra` where a direct replacement times out, so I ignored those for now.
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
These are redundant. Unfortunately there's two cases involving `GradedAlgebra` where a direct replacement times out, so I ignored those for now.
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
chore: deprecate AlgHom.map_* lemmas
[Merged by Bors] - chore: deprecate AlgHom.map_* lemmas
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
This PR has been sent to bors.
tech debt
Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are redundant. Unfortunately there's two cases involving
GradedAlgebra
where a direct replacement times out, so I ignored those for now.