[Merged by Bors] - chore(Imo/Imo1998Q2): remove resolved porting notes #14505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mo271
commented
Jul 8, 2024
mo271
commented
PR summary 5f8f603d6bImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
grunweg
reviewed
Jul 8, 2024
Archive/Imo/Imo1998Q2.lean
Outdated
| @@ -130,19 +130,17 @@ theorem A_fibre_over_contestant_card (c : C) : | |||
| ((A r).filter fun a : AgreedTriple C J => a.contestant = c).card := by | |||
| rw [A_fibre_over_contestant r] | |||
| apply Finset.card_image_of_injOn | |||
| -- Porting note (#10936): used to be `tidy`. TODO: remove `ext` after `extCore` to `aesop`. | |||
| unfold Set.InjOn; intros; ext; all_goals aesop | |||
| -- Porting note (#10936): used to be `tidy`. | |||
There was a problem hiding this comment.
I guess this porting note is no longer actionable (the tidy tactic was not ported; aesop is meant to replace it), so tend towards removing it. I'll let a maintainer comment.
grunweg
added
the
tech debt
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
grunweg
added
porting-notes
grunweg
changed the title
jcommelin
reviewed
Jul 8, 2024
Archive/Imo/Imo1998Q2.lean
Outdated
| @@ -130,19 +130,17 @@ theorem A_fibre_over_contestant_card (c : C) : | |||
| ((A r).filter fun a : AgreedTriple C J => a.contestant = c).card := by | |||
| rw [A_fibre_over_contestant r] | |||
| apply Finset.card_image_of_injOn | |||
| -- Porting note (#10936): used to be `tidy`. TODO: remove `ext` after `extCore` to `aesop`. | |||
| unfold Set.InjOn; intros; ext; all_goals aesop | |||
| -- Porting note (#10936): used to be `tidy`. | |||
|
✌️ mo271 can now approve this pull request. To approve and merge a pull request, simply reply with |
mo271
commented
Jul 8, 2024
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 8, 2024
Co-authored-by: Moritz Firsching <firsching@google.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.