[Merged by Bors] - perf(Analysis/Convex/Segment): squeeze two slow simps #14537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These new simp calls take 1 and 0.6s, respectively: squeeze them instead.
grunweg
added
awaiting-review
easy
PR summary 373aa81326Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
|
bors delegate+ Great. Please merge once CI is satisfied. |
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
|
For the record: perf run for the regressing PR, which shows the slow-down of Analysis/Convex/Segment quite clearly. |
|
Thanks for the fast review! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 8, 2024
These simp calls take 1 and 0.6s, respectively: squeeze them instead. This regressed in #14516.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These simp calls take 1 and 0.6s, respectively: squeeze them instead. This regressed in #14516.