Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: remove superfluous intros #14614

Closed
wants to merge 2 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Jul 10, 2024


Open in Gitpod

Copy link

github-actions bot commented Jul 10, 2024

PR summary 0abc04ad7b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@grunweg
Copy link
Collaborator

grunweg commented Jul 10, 2024

!bench

@grunweg
Copy link
Collaborator

grunweg commented Jul 10, 2024

FYI, the awaiting-review label was recently removed: you can simply omit it now. (See zulip for details.)

Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! These changes look good; I have one follow-up request.
Out of paranoia, I'd like to see if this makes any difference performance-wise; otherwise, this is good to go.

Mathlib/CategoryTheory/Preadditive/Biproducts.lean Outdated Show resolved Hide resolved
@grunweg grunweg added awaiting-author A reviewer has asked the author a question or requested changes awaiting-CI labels Jul 10, 2024
@grunweg grunweg self-assigned this Jul 10, 2024
@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 8ba9e11.
There were no significant changes against commit e242f1e.

@grunweg
Copy link
Collaborator

grunweg commented Jul 10, 2024

No performance effect - if you fix the nit, this is ready to be merged.

@grunweg
Copy link
Collaborator

grunweg commented Jul 12, 2024

Thanks again for your contribution!
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@grunweg grunweg removed the awaiting-author A reviewer has asked the author a question or requested changes label Jul 12, 2024
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 12, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 12, 2024
Co-authored-by: Moritz Firsching <firsching@google.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 12, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove superfluous intros [Merged by Bors] - chore: remove superfluous intros Jul 12, 2024
@mathlib-bors mathlib-bors bot closed this Jul 12, 2024
@mathlib-bors mathlib-bors bot deleted the mo271/superfluous_intros branch July 12, 2024 09:29
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants