-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: remove superfluous intro
s
#14614
Conversation
mo271
commented
Jul 10, 2024
PR summary 0abc04ad7bImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> |
!bench |
FYI, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! These changes look good; I have one follow-up request.
Out of paranoia, I'd like to see if this makes any difference performance-wise; otherwise, this is good to go.
Here are the benchmark results for commit 8ba9e11. |
No performance effect - if you fix the nit, this is ready to be merged. |
Thanks again for your contribution! |
🚀 Pull request has been placed on the maintainer queue by grunweg. |
Thanks 🎉 bors merge |
Pull request successfully merged into master. Build succeeded: |
intro
sintro
s