Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix: add assumption to autoparam isBoundedDefault #14617

Closed
wants to merge 2 commits into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Jul 10, 2024

Maybe, applyc in lean3 also tried assumption, so I added it here!

Zulip thread


Open in Gitpod

Copy link

github-actions bot commented Jul 10, 2024

PR summary 8358236561

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@sgouezel
Copy link
Contributor

Since it seems to improve the situation, let's get this in!
bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 10, 2024
@D-Thomine
Copy link
Collaborator

D-Thomine commented Jul 10, 2024

I am not completely confident in the third test case.

example : limsup u f ≤ limsup v f := by apply limsup_le_limsup h

already worked with the previous version. What failed was

example : limsup u f ≤ limsup v f := by apply limsup_le_limsup; exact h

which required two more arguments.

mathlib-bors bot pushed a commit that referenced this pull request Jul 10, 2024
@sgouezel
Copy link
Contributor

sgouezel commented Jul 10, 2024

Indeed,

  apply limsup_le_limsup
  exact h

still fails. I've already sent to bors, so the PR will be merged soon, but it doesn't solve the issue.

Note that refine limsup_le_limsup ?_ instead of apply limsup_le_limsup works as a workaround. Or even apply limsup_le_limsup ?_.

@adomani
Copy link
Collaborator Author

adomani commented Jul 10, 2024

Yes, I agree. Another workaround is

  apply (limsup_le_limsup)

and this reminds something that has changed recently. Let me see if I can find it!

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 10, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix: add assumption to autoparam isBoundedDefault [Merged by Bors] - fix: add assumption to autoparam isBoundedDefault Jul 10, 2024
@mathlib-bors mathlib-bors bot closed this Jul 10, 2024
@mathlib-bors mathlib-bors bot deleted the adomani/isBoundedDefault_assumption branch July 10, 2024 18:10
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants