-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - fix: add assumption
to autoparam isBoundedDefault
#14617
Conversation
PR summary 8358236561Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Since it seems to improve the situation, let's get this in! |
I am not completely confident in the third test case.
already worked with the previous version. What failed was
which required two more arguments. |
Maybe, `applyc` in lean3 also tried `assumption`, so I added it here! [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/239415-metaprogramming-.2F-tactics/topic/isBoundedDefault.20not.20triggering)
Indeed, apply limsup_le_limsup
exact h still fails. I've already sent to bors, so the PR will be merged soon, but it doesn't solve the issue. Note that |
Yes, I agree. Another workaround is
and this reminds something that has changed recently. Let me see if I can find it! |
Pull request successfully merged into master. Build succeeded: |
assumption
to autoparam isBoundedDefault
assumption
to autoparam isBoundedDefault
Maybe,
applyc
in lean3 also triedassumption
, so I added it here!Zulip thread